Received: from eggs.gnu.org ([2001:4830:134:3::10]:36810) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xtvq6-0003GM-1F for qemu-devel@nongnu.org; Thu, 27 Nov 2014 04:58:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xtvpz-0004vo-QU for qemu-devel@nongnu.org; Thu, 27 Nov 2014 04:58:17 -0500 Received: from mx1.redhat.com ([209.132.183.28]:48200) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xtvpz-0004vk-Hk for qemu-devel@nongnu.org; Thu, 27 Nov 2014 04:58:11 -0500 From: Markus Armbruster References: <1414947218-7618-1-git-send-email-mst@redhat.com> <87bnoouxqn.fsf@blackfin.pond.sub.org> <20141103151955.GA14401@redhat.com> <87egtkuusk.fsf@blackfin.pond.sub.org> <20141103164036.GA31267@redhat.com> <87d293qx15.fsf@blackfin.pond.sub.org> Date: Thu, 27 Nov 2014 10:58:05 +0100 In-Reply-To: <87d293qx15.fsf@blackfin.pond.sub.org> (Markus Armbruster's message of "Tue, 04 Nov 2014 07:50:46 +0100") Message-ID: <87mw7dq82a.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH] qemu-char: fix tcp_get_fds List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Paolo Bonzini , qemu-devel@nongnu.org, peter.maydell@linaro.org Markus Armbruster writes: > "Michael S. Tsirkin" writes: > >> On Mon, Nov 03, 2014 at 05:13:15PM +0100, Markus Armbruster wrote: >>> "Michael S. Tsirkin" writes: >>> >>> > On Mon, Nov 03, 2014 at 04:09:36PM +0100, Markus Armbruster wrote: >>> >> "Michael S. Tsirkin" writes: >>> >> >>> >> > tcp_get_fds API discards fds if there's more than 1 of these. >>> >> >>> >> s/tcp_get_fds/tcp_get_msgfds/ (subject as well) >>> > >>> > Right. Too late as I sent this upstream :( >>> >>> Oh, now I see: you already sent this in a pull request, after less than >>> 20 hours on list. Please don't do that except in dire emergency. It >>> sabotages our review process. >> >> I sometimes do this for patches that seem trivial to me. > > Please don't. No patch is too trivial for review. > >> I've backed this one out for now. > > Thanks. I just noticed you simply resent the thing unchanged in your next pull request. Pray tell me, why should I spend my time on reviewing your patches? Timeline: Nov 2 You submit the patch Nov 3 You include it in a pull req after <20h Nov 3 I review, ask for minor improvements You reply "too late" Peter asks you to drop it You comply Nov 23 You include it in a pull req *unchanged*, doesn't build Nov 24 You include it in a pull req *unchanged*, Peter applies