From: Markus Armbruster <armbru@redhat.com>
References: <1399996972-23429-1-git-send-email-armbru@redhat.com>
	<1399996972-23429-11-git-send-email-armbru@redhat.com>
	<5373A083.3050409@redhat.com>
Date: Wed, 14 May 2014 19:36:37 +0200
In-Reply-To: <5373A083.3050409@redhat.com> (Eric Blake's message of "Wed, 14
	May 2014 10:57:39 -0600")
Message-ID: <87mwek8dp6.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH 10/18] block/vvfat: Propagate errors
	through enable_write_target()
To: Eric Blake <eblake@redhat.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com

Eric Blake <eblake@redhat.com> writes:

> On 05/13/2014 10:02 AM, Markus Armbruster wrote:
>> Continues the conversion of the open method to Error started in commit
>> 015a103.
>> 
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> ---
>>  block/vvfat.c | 16 ++++++----------
>>  1 file changed, 6 insertions(+), 10 deletions(-)
>> 
>
>>      s->qcow = NULL;
>>      ret = bdrv_open(&s->qcow, s->qcow_filename, NULL, NULL,
>>              BDRV_O_RDWR | BDRV_O_CACHE_WB | BDRV_O_NO_FLUSH, bdrv_qcow,
>> -            &local_err);
>> +            errp);
>
> Pre-existing; indentation looks odd here if you want to touch it up at
> the same time.  But that's not a show-stopper.

Can take care of it when I respin to correct the leak in 04/18.

> Reviewed-by: Eric Blake <eblake@redhat.com>

Thanks!