Received: from eggs.gnu.org ([2001:4830:134:3::10]:43106) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UnBJC-0000uC-GR for qemu-devel@nongnu.org; Thu, 13 Jun 2013 13:27:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UnBJA-000744-JH for qemu-devel@nongnu.org; Thu, 13 Jun 2013 13:27:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:62883) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UnBJA-00073r-Cw for qemu-devel@nongnu.org; Thu, 13 Jun 2013 13:27:36 -0400 From: Markus Armbruster References: <1371106939-6968-1-git-send-email-armbru@redhat.com> <1371106939-6968-8-git-send-email-armbru@redhat.com> Date: Thu, 13 Jun 2013 19:27:29 +0200 In-Reply-To: (Peter Maydell's message of "Thu, 13 Jun 2013 17:21:08 +0100") Message-ID: <87mwqtly4e.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH RFC 7/8] exec: Don't abort when we can't allocate guest memory List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: stefano.stabellini@eu.citrix.com, mtosatti@redhat.com, agraf@suse.de, qemu-devel@nongnu.org, borntraeger@de.ibm.com, pbonzini@redhat.com Peter Maydell writes: > On 13 June 2013 08:02, Markus Armbruster wrote: >> #ifdef __linux__ >> >> +static void no_guest_mem(RAMBlock *block) >> +{ >> + fprintf(stderr, "Cannot set up guest memory '%s': %s\n", >> + block->mr->name, strerror(errno)); >> + exit(1); >> +} > > This new error message is inside an #ifdef __linux__... I'm afraid this won't compile on non-linux hosts. Will respin. Thanks! [...]