Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MGZcm-0007c5-Cx for qemu-devel@nongnu.org; Tue, 16 Jun 2009 10:26:56 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MGZch-0007Wi-NF for qemu-devel@nongnu.org; Tue, 16 Jun 2009 10:26:55 -0400 Received: from [199.232.76.173] (port=51071 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MGZch-0007Wa-Gf for qemu-devel@nongnu.org; Tue, 16 Jun 2009 10:26:51 -0400 Received: from mx2.redhat.com ([66.187.237.31]:58962) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MGZch-0007ki-1D for qemu-devel@nongnu.org; Tue, 16 Jun 2009 10:26:51 -0400 References: <87bpowhtmm.fsf@pike.pond.sub.org> From: Markus Armbruster Date: Tue, 16 Jun 2009 16:24:44 +0200 In-Reply-To: <87bpowhtmm.fsf@pike.pond.sub.org> (Markus Armbruster's message of "Wed\, 10 Jun 2009 19\:43\:29 +0200") Message-ID: <87my88uuhf.fsf@pike.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: [Qemu-devel] [PATCH] qdev: Fix regression in "pci_add ... storage if=virtio, ..." List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: paul@codesourcery.com qemu_pci_hot_add_storage() runs qdev_init() twice. Broken in commit 07e3af9a "Virtio-blk qdev conversion". Signed-off-by: Markus Armbruster --- hw/pci-hotplug.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/hw/pci-hotplug.c b/hw/pci-hotplug.c index abe5bae..4d49c29 100644 --- a/hw/pci-hotplug.c +++ b/hw/pci-hotplug.c @@ -122,7 +122,6 @@ static PCIDevice *qemu_pci_hot_add_storage(Monitor *mon, PCIBus *pci_bus, break; case IF_VIRTIO: opaque = pci_create_simple(pci_bus, -1, "virtio-blk-pci"); - qdev_init(opaque); break; } -- 1.6.0.6