From: "Huang, Ying" Subject: Re: [PATCH] mm/vmscan: respect cpuset policy during page demotion Date: Thu, 27 Oct 2022 15:39:00 +0800 Message-ID: <87o7txk963.fsf@yhuang6-desk2.ccr.corp.intel.com> References: <20221026074343.6517-1-feng.tang@intel.com> <87wn8lkbk5.fsf@yhuang6-desk2.ccr.corp.intel.com> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666856388; x=1698392388; h=from:to:cc:subject:references:date:in-reply-to: message-id:mime-version; bh=jweFWZMSXgqQ6tBTe/QKSoQxmkPbv29fClDdATqJ80E=; b=BdCDXRUb2vVUxO8Smrn4RhyqAaRdb0nRBKtrpMdJ0pJMtGoMcnehdKCL voaHKd6tLGBvIk9y9oqpBBntTI8GTf+VdueqLSmpj+nbQlESqqrpMthoJ F1h8TRNsl5Qpm3011kaBG8oS5KT1dCjI8njVvIG3ercfnFqmom3cYGT8x s7qSumZG6eVdoOgx4IIafpp4MHEQnvuoXdXBCWLVWQL5WlE0azcJEDeJ6 SjXwb28ZTEqCFstvMzy2iCPwrnN8Y0JZ4sc3obp49JTfTJKHzcSQLE8zJ tm3+qV9T2D2YkBTDVNek/3RBtFRQ7ILpRZXtVMn++XspCVfS/lmDv0uRA A==; In-Reply-To: (Michal Hocko's message of "Thu, 27 Oct 2022 09:10:28 +0200") List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Michal Hocko Cc: Feng Tang , Aneesh Kumar K V , Andrew Morton , Johannes Weiner , Tejun Heo , Zefan Li , Waiman Long , "linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org" , "cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "Hansen, Dave" , "Chen, Tim C" , "Yin, Fengwei" Michal Hocko writes: > On Thu 27-10-22 14:47:22, Huang, Ying wrote: >> Michal Hocko writes: > [...] >> > I can imagine workloads which wouldn't like to get their memory demoted >> > for some reason but wouldn't it be more practical to tell that >> > explicitly (e.g. via prctl) rather than configuring cpusets/memory >> > policies explicitly? >> >> If my understanding were correct, prctl() configures the process or >> thread. > > Not necessarily. There are properties which are per adddress space like > PR_[GS]ET_THP_DISABLE. This could be very similar. > >> How can we get process/thread configuration at demotion time? > > As already pointed out in previous emails. You could hook into > folio_check_references path, more specifically folio_referenced_one > where you have all that you need already - all vmas mapping the page and > then it is trivial to get the corresponding vm_mm. If at least one of > them has the flag set then the demotion is not allowed (essentially the > same model as VM_LOCKED). Got it! Thanks for detailed explanation. One bit may be not sufficient. For example, if we want to avoid or control cross-socket demotion and still allow demoting to slow memory nodes in local socket, we need to specify a node mask to exclude some NUMA nodes from demotion targets. From overhead point of view, this appears similar as that of VMA/task memory policy? We can make mm->owner available for memory tiers (CONFIG_NUMA && CONFIG_MIGRATION). The advantage is that we don't need to introduce new ABI. I guess users may prefer to use `numactl` than a new ABI? Best Regards, Huang, Ying