From: Peter Korsgaard Date: Thu, 24 Oct 2019 10:30:05 +0200 Subject: [Buildroot] [PATCH v4 1/1] package/libsodium: add config for full build In-Reply-To: <91913550-aa51-4b85-225b-e1b674e91e66@mind.be> (Arnout Vandecappelle's message of "Sun, 29 Sep 2019 12:51:35 +0200") References: <20190923082902.28472-1-adrien@gallouet.fr> <20190928231934.236e5f83@windsurf> <20190929090408.67e6d38e@windsurf> <91913550-aa51-4b85-225b-e1b674e91e66@mind.be> Message-ID: <87o8y65ywi.fsf@dell.be.48ers.dk> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net >>>>> "Arnout" == Arnout Vandecappelle writes: Hi, >> I don't have a very clear-cut opinion. >> >> On one hand, it is weird to have a Config.in option to reduce/remove >> something. But on the other hand, it makes sense to have Config.in >> options that are as much as possible mapped to the corresponding >> options provided by the package build system. >> >> Arnout, Peter, any preference ? > It was me who suggested to turn around the logic. > I believe we have had problems in the past where there was some MINIMAL option, > but then some other package needed something from the non-minimal set. Then it > has to do a 'depends on' instead of a 'select'. > So it's not a matter of being weird, it's a matter of making sure we don't > create problems in the future. Agreed, having options to disable stuff gets tricky when you have other packages needing the disabled stuff. >>> Also, we need to pass --disable-minimal in an "else" clause. > This is still true. Adrien, I believe I did say something to that effect in an > earlier iteration, and I also believe you replied to it. But my memory is > worthless :-) Getting old? :P -- Bye, Peter Korsgaard