From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Subject: Re: [PATCH] drm/i915: don't leak the pin_map on error
Date: Thu, 01 Mar 2018 12:25:32 +0200
Message-ID: <87o9k8qehv.fsf@gaia.fi.intel.com>
References: <20180301101855.670-1-matthew.auld@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga12.intel.com (mga12.intel.com [192.55.52.136])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 841D06EC1C
 for <intel-gfx@lists.freedesktop.org>; Thu,  1 Mar 2018 10:29:58 +0000 (UTC)
In-Reply-To: <20180301101855.670-1-matthew.auld@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Matthew Auld <matthew.auld@intel.com>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

TWF0dGhldyBBdWxkIDxtYXR0aGV3LmF1bGRAaW50ZWwuY29tPiB3cml0ZXM6Cgo+IEFkZCBzb21l
IG9uaW9uIHRvIHBvcHVsYXRlX2xyX2NvbnRleHQuCj4KPiBGaXhlczogZDJiNGI5NzkzM2Y1ICgi
ZHJtL2k5MTU6IFJlY29yZCB0aGUgZGVmYXVsdCBodyBzdGF0ZSBhZnRlciByZXNldCB1cG9uIGxv
YWQiKQo+IFNpZ25lZC1vZmYtYnk6IE1hdHRoZXcgQXVsZCA8bWF0dGhldy5hdWxkQGludGVsLmNv
bT4KPiBDYzogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4gLS0tCj4g
IGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jIHwgMTAgKysrKysrLS0tLQo+ICAxIGZp
bGUgY2hhbmdlZCwgNiBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdp
dCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jIGIvZHJpdmVycy9ncHUvZHJtL2k5
MTUvaW50ZWxfbHJjLmMKPiBpbmRleCAxNDI4ODc0MzkwOWYuLjlkZDY0NDBlYjBlMSAxMDA2NDQK
PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYwo+ICsrKyBiL2RyaXZlcnMv
Z3B1L2RybS9pOTE1L2ludGVsX2xyYy5jCj4gQEAgLTIzMTgsOCArMjMxOCwxMCBAQCBwb3B1bGF0
ZV9scl9jb250ZXh0KHN0cnVjdCBpOTE1X2dlbV9jb250ZXh0ICpjdHgsCj4gIAo+ICAJCWRlZmF1
bHRzID0gaTkxNV9nZW1fb2JqZWN0X3Bpbl9tYXAoZW5naW5lLT5kZWZhdWx0X3N0YXRlLAo+ICAJ
CQkJCQkgICBJOTE1X01BUF9XQik7Cj4gLQkJaWYgKElTX0VSUihkZWZhdWx0cykpCj4gLQkJCXJl
dHVybiBQVFJfRVJSKGRlZmF1bHRzKTsKPiArCQlpZiAoSVNfRVJSKGRlZmF1bHRzKSkgewo+ICsJ
CQlyZXQgPSBQVFJfRVJSKGRlZmF1bHRzKTsKPiArCQkJZ290byBlcnJvcjsKCkkgd291bGQgaGF2
ZSB1c2VkIGdvdG8gdW5waW5fb3V0IG9yIGVycm9yX3VucGluLiBUaGlzCndheSB5b3UgY2FuIHJl
YWQgYm90aCBwYXJ0cyBzZXBhcmF0ZWx5IGFuZCBkb24ndCBoYXZlIHRvCmdvIGJhY2sgYW5kIGZv
cnRoIHBhaXJpbmcgdGhlIHBhcnRzIG9mIG9uaW9uLiBKdXN0CmEgc3R5bGlzdGljIG5vdGUgYW5k
IGFzIHRoaXMgaXMgdGhlIG9ubHkgZ290byBpbiB0aGlzCmZ1bmMgc28gd2UgY2FuIGltcHJvdmUg
aWYgaXQgZXZlciBncm93cy4KClJldmlld2VkLWJ5OiBNaWthIEt1b3BwYWxhIDxtaWthLmt1b3Bw
YWxhQGxpbnV4LmludGVsLmNvbT4KCj4gKwkJfQo+ICAKPiAgCQltZW1jcHkodmFkZHIgKyBzdGFy
dCwgZGVmYXVsdHMgKyBzdGFydCwgZW5naW5lLT5jb250ZXh0X3NpemUpOwo+ICAJCWk5MTVfZ2Vt
X29iamVjdF91bnBpbl9tYXAoZW5naW5lLT5kZWZhdWx0X3N0YXRlKTsKPiBAQCAtMjMzNyw5ICsy
MzM5LDkgQEAgcG9wdWxhdGVfbHJfY29udGV4dChzdHJ1Y3QgaTkxNV9nZW1fY29udGV4dCAqY3R4
LAo+ICAJCQlfTUFTS0VEX0JJVF9FTkFCTEUoQ1RYX0NUUkxfRU5HSU5FX0NUWF9SRVNUT1JFX0lO
SElCSVQgfAo+ICAJCQkJCSAgIENUWF9DVFJMX0VOR0lORV9DVFhfU0FWRV9JTkhJQklUKTsKPiAg
Cj4gK2Vycm9yOgo+ICAJaTkxNV9nZW1fb2JqZWN0X3VucGluX21hcChjdHhfb2JqKTsKPiAtCj4g
LQlyZXR1cm4gMDsKPiArCXJldHVybiByZXQ7Cj4gIH0KPiAgCj4gIHN0YXRpYyBpbnQgZXhlY2xp
c3RzX2NvbnRleHRfZGVmZXJyZWRfYWxsb2Moc3RydWN0IGk5MTVfZ2VtX2NvbnRleHQgKmN0eCwK
PiAtLSAKPiAyLjE0LjMKPgo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fCj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+IEludGVsLWdmeEBsaXN0cy5mcmVl
ZGVza3RvcC5vcmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp
bmZvL2ludGVsLWdmeApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5v
cmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1n
ZngK