Received: from eggs.gnu.org ([2001:4830:134:3::10]:42031) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQECz-0006sp-JB for qemu-devel@nongnu.org; Mon, 01 Feb 2016 08:07:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aQECw-0001Q0-Cg for qemu-devel@nongnu.org; Mon, 01 Feb 2016 08:07:57 -0500 From: Markus Armbruster References: <1454075341-13658-1-git-send-email-eblake@redhat.com> <1454075341-13658-24-git-send-email-eblake@redhat.com> Date: Mon, 01 Feb 2016 14:07:50 +0100 In-Reply-To: <1454075341-13658-24-git-send-email-eblake@redhat.com> (Eric Blake's message of "Fri, 29 Jan 2016 06:48:59 -0700") Message-ID: <87oac060k9.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v10 23/25] qapi: Drop unused error argument for list and implicit struct List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Michael Roth , Alexander Graf , qemu-devel@nongnu.org, "open list:sPAPR" , marcandre.lureau@redhat.com, David Gibson Eric Blake writes: > No backend was setting an error when ending an implicit struct, > or when iterating a list. Perhaps "when ending the visit of a list or implicit struct, or when moving to the next list node" would be more precise. If you like it, I can do that on commit. > Make the callers a bit easier to follow > by making this a part of the contract, and removing the errp > argument - callers can then unconditionally end an object as > part of cleanup without having to think about whether a second > error is dominated by a first, because there is no second error. > > A later patch will then tackle the larger task of splitting > visit_end_struct(), which can indeed set an error (and that > cleanup will also have the side-effect of removing the use of > error_abort added here). > > Signed-off-by: Eric Blake > > --- > v10: split out qmp input changes, also fix visit_next_list(), drop R-b > v9: enhance commit message > v8: no change > v7: place earlier in series, rebase to earlier changes > v6: new patch, split from RFC on v5 7/46 Patch looks good.