From: Kalle Valo Date: Tue, 08 Dec 2015 16:56:21 +0200 Subject: [ath9k-devel] [PATCH V2] ath9k: Simplify and fix eeprom endianness swapping In-Reply-To: <1446296252-11083-1-git-send-email-martin.blumenstingl@googlemail.com> (Martin Blumenstingl's message of "Sat, 31 Oct 2015 13:57:32 +0100") References: <1444862012-25376-2-git-send-email-martin.blumenstingl@googlemail.com> <1446296252-11083-1-git-send-email-martin.blumenstingl@googlemail.com> Message-ID: <87oae19ega.fsf@kamboji.qca.qualcomm.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ath9k-devel@lists.ath9k.org Martin Blumenstingl writes: > The three eeprom implementations had quite some duplicate code when it > came to endianness swapping. > Additionally there was a bug in eeprom_4k and eeprom_9287 which > prevented the endianness swapping from working correctly, because the > swapping code was guarded within an "if (!ath9k_hw_use_flash(ah))". In > eeprom_def this check did not exist, so it seems that eeprom_def was the > only implementation where endianness swapping worked. > > This patch takes the duplicate code and moves it from eeprom_* to > eeprom.c. The new code is derived from eeprom_def, while taking into > account the specifics from the other implementations. > > Signed-off-by: Martin Blumenstingl Applied to ath.git, thanks. -- Kalle Valo