Received: from eggs.gnu.org ([2001:4830:134:3::10]:60780) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YxGGa-0003cW-Mf for qemu-devel@nongnu.org; Tue, 26 May 2015 10:55:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YxGGX-0004kB-Cg for qemu-devel@nongnu.org; Tue, 26 May 2015 10:55:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36092) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YxGGX-0004k5-7q for qemu-devel@nongnu.org; Tue, 26 May 2015 10:55:37 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 3123DBDD71 for ; Tue, 26 May 2015 14:55:36 +0000 (UTC) From: Markus Armbruster References: <1432294585-5984-1-git-send-email-armbru@redhat.com> <1432294585-5984-5-git-send-email-armbru@redhat.com> <555FA2E4.2000409@redhat.com> <87iobfem19.fsf@blackfin.pond.sub.org> <1432644705.24602.8.camel@nilsson.home.kraxel.org> <20150526125241.GA30049@redhat.com> <87lhgb4edp.fsf@blackfin.pond.sub.org> <1432649704.24602.17.camel@nilsson.home.kraxel.org> Date: Tue, 26 May 2015 16:55:33 +0200 In-Reply-To: <1432649704.24602.17.camel@nilsson.home.kraxel.org> (Gerd Hoffmann's message of "Tue, 26 May 2015 16:15:04 +0200") Message-ID: <87oal71j8a.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH 04/20] monitor: Convert client_migrate_info to QAPI List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org, lcapitulino@redhat.com Gerd Hoffmann writes: > Hi, > >> Should we continue to document the command is about "spice/vnc >> connection info", or should we rephrase? Something like: >> >> client_migrate_info >> ------------------- >> >> Set remote display connection information for migration. This makes the >> server ask the client to automatically reconnect using the new >> parameters once migration finished successfully. Only implemented for >> SPICE. >> >> Arguments: >> >> - "protocol": must be "spice" (json-string) >> - "hostname": migration target hostname (json-string) >> - "port": spice/vnc tcp port for plaintext channels (json-int, >> optional) >> - "tls-port": spice tcp port for tls-secured channels (json-int, optional) >> - "cert-subject": server certificate subject (json-string, optional) > > Looks good to me. Okay, I'll squash something like that into PATCH 03, and cc: you for review.