From: Peter Korsgaard Date: Wed, 04 Mar 2015 23:30:21 +0100 Subject: [Buildroot] [PATCH 1/2] package/vlc: express the dependency on freerdp In-Reply-To: <20150304232410.175ac1ed@free-electrons.com> (Thomas Petazzoni's message of "Wed, 4 Mar 2015 23:24:10 +0100") References: <20150304232410.175ac1ed@free-electrons.com> Message-ID: <87oao8s8ea.fsf@dell.be.48ers.dk> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net >>>>> "Thomas" == Thomas Petazzoni writes: > Dear Yann E. MORIN, > On Wed, 4 Mar 2015 23:15:33 +0100, Yann E. MORIN wrote: >> vlc can use the freerdp library if present. >> >> This is currently a hidden dependency, as we do not express it in our >> vlc.mk rules. Package ordering makes it so that freerdp is built before >> vlc; however, manually building vlc (with 'make vlc') would miss the >> dependency because of that package ordering. >> >> Explcitly add freerdp (if enabled) as a dependency of vlc to ensure >> build order in every vases. > a vase is for flowers, I guess you wanted to say 'case', right? > Committed with this fixed. But you forgot to fix the 'Explcitly' in the line above. -- Bye, Peter Korsgaard