From: Markus Armbruster <armbru@redhat.com>
References: <1399996972-23429-1-git-send-email-armbru@redhat.com>
	<1399996972-23429-12-git-send-email-armbru@redhat.com>
	<5373ABB8.5020004@redhat.com>
Date: Wed, 14 May 2014 21:48:20 +0200
In-Reply-To: <5373ABB8.5020004@redhat.com> (Eric Blake's message of "Wed, 14
	May 2014 11:45:28 -0600")
Message-ID: <87oaz06t17.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH 11/18] block/vvfat: Propagate errors
	through init_directories()
To: Eric Blake <eblake@redhat.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com

Eric Blake <eblake@redhat.com> writes:

> On 05/13/2014 10:02 AM, Markus Armbruster wrote:
>> Completes the conversion of the open method to Error started in commit
>> 015a103.
>> 
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> ---
>>  block/vvfat.c | 16 +++++++++-------
>>  1 file changed, 9 insertions(+), 7 deletions(-)
>> 
>> @@ -892,8 +893,8 @@ static int init_directories(BDRVVVFATState* s,
>>          if (mapping->mode & MODE_DIRECTORY) {
>>  	    mapping->begin = cluster;
>>  	    if(read_directory(s, i)) {
>> -		fprintf(stderr, "Could not read directory %s\n",
>> -			mapping->path);
>> +                error_setg(errp, "Could not read directory %s",
>> +                           mapping->path);
>
> I see you fixed some TABs in the process; is it worth widening the fix
> to the rest of the 'if' statement?  I don't care either way, as long as
> checkpatch.pl didn't call you out (the new code is correct, even though
> the existing code was not).

checkpatch is happy.

The fewer lines in vvfat.c git blames on me, the happier I am ;)

> Reviewed-by: Eric Blake <eblake@redhat.com>

Thanks!