From: OGAWA Hirofumi Subject: Re: [PATCH 3/5] fat: zero out seek range on _fat_get_block Date: Sun, 27 Oct 2013 22:45:37 +0900 Message-ID: <87ob6ayghq.fsf@devron.myhome.or.jp> References: <1381329653-11905-1-git-send-email-linkinjeon@gmail.com> <87sivmygnq.fsf@devron.myhome.or.jp> Mime-Version: 1.0 Content-Type: text/plain Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, a.sahrawat@samsung.com, Namjae Jeon To: Namjae Jeon Return-path: In-Reply-To: <87sivmygnq.fsf@devron.myhome.or.jp> (OGAWA Hirofumi's message of "Sun, 27 Oct 2013 22:42:01 +0900") Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org OGAWA Hirofumi writes: > Namjae Jeon writes: > >> + last_block = (MSDOS_I(inode)->mmu_private + (blocksize - 1)) >> + >> blocksize_bits; >> + disk_block = (MSDOS_I(inode)->i_disksize + (blocksize - 1)) >> + >> blocksize_bits; >> + if (iblock >= last_block && iblock <= disk_block) { >> + MSDOS_I(inode)->mmu_private += >> + *max_blocks << blocksize_bits; > > Hm, mmu_private is not increased by write_begin()? Ah, ok. I understood what this is doing. Please ignore this comment. -- OGAWA Hirofumi