Received: from eggs.gnu.org ([2001:4830:134:3::10]:39804) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VQhQH-0001Tm-4x for qemu-devel@nongnu.org; Mon, 30 Sep 2013 13:38:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VQhQB-0001gC-C4 for qemu-devel@nongnu.org; Mon, 30 Sep 2013 13:38:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57721) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VQhQB-0001fj-3I for qemu-devel@nongnu.org; Mon, 30 Sep 2013 13:38:11 -0400 From: Markus Armbruster References: <1380452123-5989-1-git-send-email-mst@redhat.com> <1380452123-5989-2-git-send-email-mst@redhat.com> <20130930151056.32699e7f@nial.usersys.redhat.com> <20130930144050.GB22806@redhat.com> <8738om1f95.fsf@blackfin.pond.sub.org> <20130930160957.GB13918@redhat.com> Date: Mon, 30 Sep 2013 19:38:04 +0200 In-Reply-To: <20130930160957.GB13918@redhat.com> (Michael S. Tsirkin's message of "Mon, 30 Sep 2013 19:09:57 +0300") Message-ID: <87ob7aus5f.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v6 01/26] qemu: add Error to typedefs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Peter Maydell , QEMU Developers , Gerd Hoffmann , Igor Mammedov , Paolo Bonzini , Andreas =?utf-8?Q?F=C3=A4rber?= "Michael S. Tsirkin" writes: > On Mon, Sep 30, 2013 at 05:49:26PM +0200, Markus Armbruster wrote: >> Peter Maydell writes: >> >> > On 30 September 2013 23:40, Michael S. Tsirkin wrote: >> >> diff --git a/include/qapi/error.h b/include/qapi/error.h >> >> index 7d4c696..b85e996 100644 >> >> --- a/include/qapi/error.h >> >> +++ b/include/qapi/error.h >> >> @@ -13,14 +13,15 @@ >> >> #define ERROR_H >> >> >> >> #include "qemu/compiler.h" >> >> +#include "qemu/typedefs.h" >> >> #include "qapi-types.h" >> >> #include >> >> >> >> /** >> >> - * A class representing internal errors within QEMU. An error has a ErrorClass >> >> + * Error: >> >> + * An object representing internal errors within QEMU. An error has a ErrorClass >> >> * code and a human message. >> >> */ >> >> -typedef struct Error Error; >> > >> > Does the process-doc-comments tool really cope with documentation comments >> > that are completely separate from the typedef like this? >> >> Even if they do, I don't. > > What kind of error do you encounter? Even if $magic-tool could somehow find the documentation comments even when they're far from the definitions they apply to, non-magic old me can't.