Received: from eggs.gnu.org ([208.118.235.92]:60290) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UVkXB-0000L5-U4 for qemu-devel@nongnu.org; Fri, 26 Apr 2013 11:26:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UVkXA-0003st-Hi for qemu-devel@nongnu.org; Fri, 26 Apr 2013 11:26:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43210) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UVkXA-0003sn-6k for qemu-devel@nongnu.org; Fri, 26 Apr 2013 11:26:00 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r3QFPxuZ000368 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 26 Apr 2013 11:25:59 -0400 From: Markus Armbruster References: <20130424163641.3e15bd43@redhat.com> <51784913.6020209@redhat.com> <20130424172911.753616ea@redhat.com> <517855B3.6060604@redhat.com> <20130425082635.5333288a@redhat.com> <517A3747.3090301@redhat.com> <87k3np9zqu.fsf@blackfin.pond.sub.org> <20130426095454.68e7bdae@redhat.com> Date: Fri, 26 Apr 2013 17:25:57 +0200 In-Reply-To: <20130426095454.68e7bdae@redhat.com> (Luiz Capitulino's message of "Fri, 26 Apr 2013 09:54:54 -0400") Message-ID: <87obd15n5m.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH for-1.5] qmp: add query-drive-mirror-capabilities List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: Kevin Wolf , Paolo Bonzini , qemu-devel Luiz Capitulino writes: > On Fri, 26 Apr 2013 15:40:25 +0200 > Markus Armbruster wrote: > >> Paolo Bonzini writes: >> >> > Il 25/04/2013 14:26, Luiz Capitulino ha scritto: >> >> That's a good point, although I wonder if a command could have a new >> >> capability that's not mapped to a new argument. IOW, I'd expect most/all >> >> new capabilities to always be mapped to new arguments. >> > >> > A new enum value would also be a new capability, but it's handled better >> > by enabling introspection of enum values. >> >> An extension that adds neither arguments nor argument values is probably >> an incompatible change, not a proper extension. Don't do that then. > > I think Paolo is referring to a command that takes an enumeration as > an argument, eg. transaction. Extending the enumeration adds argument values, i.e. it's just fine.