Received: from eggs.gnu.org ([208.118.235.92]:37425) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1USl4U-0000X0-SO for qemu-devel@nongnu.org; Thu, 18 Apr 2013 05:24:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1USl4T-0006yL-IA for qemu-devel@nongnu.org; Thu, 18 Apr 2013 05:24:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54621) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1USl4T-0006yG-9s for qemu-devel@nongnu.org; Thu, 18 Apr 2013 05:24:01 -0400 From: Markus Armbruster References: Date: Thu, 18 Apr 2013 11:23:46 +0200 In-Reply-To: (Hu Tao's message of "Thu, 18 Apr 2013 10:14:42 +0800") Message-ID: <87obdcgpjx.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v19 3/7] introduce a new qom device to deal with panicked event List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hu Tao Cc: Peter Maydell , Gleb Natapov , "Michael S. Tsirkin" , Jan Kiszka , qemu-devel , Luiz Capitulino , Blue Swirl , Orit Wasserman , Juan Quintela , Alexander Graf , Christian Borntraeger , Andrew Jones , Alex Williamson , Sasha Levin , Stefan Hajnoczi , KAMEZAWA Hiroyuki , Anthony Liguori , Marcelo Tosatti , Paolo Bonzini Hu Tao writes: > pvpanic device is used to send guest panic event from guest to qemu. > > When guest panic happens, pvpanic device driver will write a event > number to IO port 0x505(which is the IO port occupied by pvpanic device, > by default). On receiving the event, pvpanic device will pause guest > cpu(s), and send a qmp event QEVENT_GUEST_PANICKED. > > Signed-off-by: Wen Congyang > Signed-off-by: Hu Tao > --- > hw/misc/Makefile.objs | 2 + > hw/misc/pvpanic.c | 123 ++++++++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 125 insertions(+) > create mode 100644 hw/misc/pvpanic.c > > diff --git a/hw/misc/Makefile.objs b/hw/misc/Makefile.objs > index 03699c3..d72ea83 100644 > --- a/hw/misc/Makefile.objs > +++ b/hw/misc/Makefile.objs > @@ -38,3 +38,5 @@ obj-$(CONFIG_OMAP) += omap_tap.o > obj-$(CONFIG_PXA2XX) += pxa2xx_pcmcia.o > obj-$(CONFIG_SLAVIO) += slavio_misc.o > obj-$(CONFIG_ZYNQ) += zynq_slcr.o > + > +common-obj-y += pvpanic.o > diff --git a/hw/misc/pvpanic.c b/hw/misc/pvpanic.c > new file mode 100644 > index 0000000..c3adcdf > --- /dev/null > +++ b/hw/misc/pvpanic.c > @@ -0,0 +1,123 @@ > +/* > + * QEMU simulated pvpanic device. > + * > + * Copyright Fujitsu, Corp. 2013 > + * > + * Authors: > + * Wen Congyang > + * Hu Tao > + * > + * This work is licensed under the terms of the GNU GPL, version 2 or later. > + * See the COPYING file in the top-level directory. > + * > + */ > + > +#include > +#include > +#include > +#include > +#include > + > +/* The bit of supported pv event */ > +#define PVPANIC_F_PANICKED 0 > + > +/* The pv event value */ > +#define PVPANIC_PANICKED (1 << PVPANIC_F_PANICKED) > + > +#define TYPE_ISA_PVPANIC_DEVICE "pvpanic" > +#define ISA_PVPANIC_DEVICE(obj) \ > + OBJECT_CHECK(PVPanicState, (obj), TYPE_ISA_PVPANIC_DEVICE) > + > +static void panicked_mon_event(const char *action) > +{ > + QObject *data; > + > + data = qobject_from_jsonf("{ 'action': %s }", action); > + monitor_protocol_event(QEVENT_GUEST_PANICKED, data); > + qobject_decref(data); > +} > + > +static void handle_event(int event) > +{ > + static bool logged; > + > + if (event & ~PVPANIC_PANICKED && !logged) { > + fprintf(stderr, "pvpanic: unknown event %#x.\n", event); > + logged = true; > + } qemu_log_mask(LOG_GUEST_ERROR, ...)? Could be done on top, without a respin. > + > + if (event & PVPANIC_PANICKED) { > + panicked_mon_event("pause"); > + vm_stop(RUN_STATE_GUEST_PANICKED); > + return; > + } > +} [...]