From: Sven Joachim Subject: drm: refresh rate down to 60 Hz in 2.6.35-rc5 Date: Wed, 14 Jul 2010 21:09:33 +0200 Message-ID: <87oce9khhu.fsf@turtle.gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Sender: linux-kernel-owner@vger.kernel.org To: dri-devel@lists.freedesktop.org Cc: Adam Jackson , Dave Airlie , linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org [ Resending to the right mailing list. I looked up in MAINTAINERS, but forgot to run "git bisect reset" and got the wrong address for dri-devel@. Apologies to all who receive this twice. ] After upgrading to 2.6.35-rc5, I noticed that my monitor reports a refresh rate of 60 Hz when nouveau.ko is loaded, rather than the 75 Hz = I got on 2.6.34. Graphics card is an NV86 (GeForce 8500 GT), the monitor is a 1280x1024 TFT (Yakumo 19AL) connected via VGA. I bisected this to the following commit: --8<---------------cut here---------------start------------->8--- commit c867df7043b738da4f4d358d7039c243a29b4272 Author: Adam Jackson Date: Mon Mar 29 21:43:21 2010 +0000 drm/edid: Reshuffle mode list construction to closer match the spec =20 Also, document what the spec says to do. =20 Signed-off-by: Adam Jackson Signed-off-by: Dave Airlie diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 9c4717f..858fedc 100644 --- a/drivers/gpu/drm/drm_edid.c +++ b/drivers/gpu/drm/drm_edid.c @@ -1377,10 +1377,24 @@ int drm_add_edid_modes(struct drm_connector *co= nnector, struct edid *edid) =20 quirks =3D edid_get_quirks(edid); =20 - num_modes +=3D add_established_modes(connector, edid); - num_modes +=3D add_standard_modes(connector, edid); + /* + * EDID spec says modes should be preferred in this order: + * - preferred detailed mode + * - other detailed modes from base block + * - detailed modes from extension blocks + * - CVT 3-byte code modes + * - standard timing codes + * - established timing codes + * - modes inferred from GTF or CVT range information + * + * We don't quite implement this yet, but we're close. + * + * XXX order for additional mode types in extension blocks? + */ num_modes +=3D add_detailed_info(connector, edid, quirks); num_modes +=3D add_detailed_info_eedid(connector, edid, quirks); + num_modes +=3D add_standard_modes(connector, edid); + num_modes +=3D add_established_modes(connector, edid); =20 if (quirks & (EDID_QUIRK_PREFER_LARGE_60 | EDID_QUIRK_PREFER_LARGE_75= )) edid_fixup_preferred(connector, quirks); --8<---------------cut here---------------end--------------->8--- How do I get the 75 Hz refresh rate back? Adding "video=3D1280x1024@75= " as described in the nouveau wiki=B9 has no effect. Regards, Sven =B9 http://nouveau.freedesktop.org/wiki/KernelModeSetting