Subject: Re: [Qemu-devel] [PATCH] qemu_reserve_isa_irq()
References: <4A7ADE70.7060204@sgi.com> <4A806D86.8090208@codemonkey.ws>
	<4A8156D4.2090000@sgi.com> <4A817B61.2010803@redhat.com>
	<4A818415.8020706@sgi.com> <4A81D666.2010404@redhat.com>
From: Markus Armbruster <armbru@redhat.com>
Date: Fri, 14 Aug 2009 10:40:21 +0200
In-Reply-To: <4A81D666.2010404@redhat.com> (Gerd Hoffmann's message of "Tue\,
	11 Aug 2009 22\:36\:54 +0200")
Message-ID: <87ocqiokju.fsf@pike.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, Jes Sorensen <jes@sgi.com>, qemu-devel <qemu-devel@nongnu.org>, Gleb Natapov <gleb@redhat.com>

Gerd Hoffmann <kraxel@redhat.com> writes:

> Attached a patch.  It will:
>
>   (1) make isa-bus maintain isa irqs, complain when allocating
>       already taken irqs.
>   (2) note that (1) works only for isa devices converted to qdev
>       already (floppy and ps2/kbd/mouse right now), so more work
>       is needed to make this really useful.
>   (3) split floppy init into isa and sysbus versions.
>   (4) add sysbus->isa bridge & fix -M isapc breakage.

It fixes this:

$ qemu tmp.qcow2 -S -M isapc
Tried to create isa device i8042 with no isa bus present.
Segmentation fault (core dumped)