Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F3916A010 for ; Tue, 30 Jan 2024 12:43:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706618616; cv=none; b=eMOpHh6eCwEHjyppXb3paxHP77HwalZ+ES4badq/U6OuEODepz3uppV/fke/5A18yKtTvj1fJokhqgGSj6Npz8SzEkcflwqAS0x2b6ZDpewMlv5cfDpHw+6pf1A8yggcaldN/FIGJ4QKZvgFYlXTy0pt1KXacxjMVeDvF4LyJPA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706618616; c=relaxed/simple; bh=6AuILVSfo995vrGWqoJwLioZFKPpmYA0IgTcq30CeS8=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=amtUaY5RvCcQoxVwtraERfVMLyOZDf8Y5ok2kVrWUk5oiyzEyLMm20cqf5p264q7RMnQQ+rbLV1H1Zs83NSQR0EzfLGlVJ1P6v6zjLm1Yxln6uTMFFRLdHwfPzSioGmcnwNdG2IEnALPpfwaGhQW89ad2DYGSZeUKdcDvzy/jTA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=u9edosx+; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="u9edosx+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1FE6AC433F1; Tue, 30 Jan 2024 12:43:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706618616; bh=6AuILVSfo995vrGWqoJwLioZFKPpmYA0IgTcq30CeS8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=u9edosx+aaaEDT1wiQK7kYyPEoNxcxymytMhpFPVprBN7tZUDyi2Ewl5N0s5kBl+I p2q7Eg9jI6kmD8bgViEusJ0yOhSPdG9ciPgnuodhXo+VRZTMqxYJ0EtZmg8D3DvixM 8JO28Pp0jgP7ZkbZYwat2n2w7cUQ/kQXImngJcOBoYgZtdYQ4yimSK+5zopV6twX5Y T0ptGC1hFZNsc5Wg7s7ncoNgLzJME3x8LwsTASDdS9OldkhhG9+tFBP+uplLckDtVY 9XPOjlNqaqFs6z8heNCzOsD6quqG3cmkaU7Aw/PcVTWJOjF1UqtIqzqKD0Ze5tRmIi MqUaz1lSp/JGw== Received: from [12.161.88.66] (helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rUnSf-00GG2X-GG; Tue, 30 Jan 2024 12:43:33 +0000 Date: Tue, 30 Jan 2024 12:43:29 +0000 Message-ID: <87plxjvvny.wl-maz@kernel.org> From: Marc Zyngier To: Joey Gouly Cc: kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, James Morse , Suzuki K Poulose , Oliver Upton , Zenghui Yu , Catalin Marinas , Will Deacon , Mark Brown Subject: Re: [PATCH 16/25] KVM: arm64: Rename __check_nv_sr_forward() to triage_sysreg_trap() In-Reply-To: <20240124165720.GL1283334@e124191.cambridge.arm.com> References: <20240122201852.262057-1-maz@kernel.org> <20240122201852.262057-17-maz@kernel.org> <20240124165720.GL1283334@e124191.cambridge.arm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 12.161.88.66 X-SA-Exim-Rcpt-To: joey.gouly@arm.com, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, james.morse@arm.com, suzuki.poulose@arm.com, oliver.upton@linux.dev, yuzenghui@huawei.com, catalin.marinas@arm.com, will@kernel.org, broonie@kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Wed, 24 Jan 2024 16:57:20 +0000, Joey Gouly wrote: > > > +bool triage_sysreg_trap(struct kvm_vcpu *vcpu, int *sr_index); > > + > > #define AA32(_x) .aarch32_map = AA32_##_x > > #define Op0(_x) .Op0 = _x > > #define Op1(_x) .Op1 = _x > > It's strange having triage_sysreg_trap() in emulate-nested.c, but moving that > would be churn for little benefit. Maybe once NV is all in. My plan is to rename this to something like 'exception-routing.c', because that's what it is all about. Thoughts? M. -- Without deviation from the norm, progress is not possible.