Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3273C433FE for ; Wed, 15 Dec 2021 11:04:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234111AbhLOLEM (ORCPT ); Wed, 15 Dec 2021 06:04:12 -0500 Received: from mga07.intel.com ([134.134.136.100]:54393 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234048AbhLOLEM (ORCPT ); Wed, 15 Dec 2021 06:04:12 -0500 X-IronPort-AV: E=McAfee;i="6200,9189,10198"; a="302576978" X-IronPort-AV: E=Sophos;i="5.88,207,1635231600"; d="scan'208";a="302576978" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Dec 2021 03:04:11 -0800 X-IronPort-AV: E=Sophos;i="5.88,207,1635231600"; d="scan'208";a="465553346" Received: from adalyx-mobl1.ger.corp.intel.com (HELO localhost) ([10.252.7.70]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Dec 2021 03:04:07 -0800 From: Jani Nikula To: Thomas Zimmermann , mripard@kernel.org, maarten.lankhorst@linux.intel.com, airlied@linux.ie, daniel@ffwll.ch Cc: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-tegra@vger.kernel.org, Thomas Zimmermann Subject: Re: [PATCH v2 3/5] drm/dp: Move DisplayPort helpers into separate helper module In-Reply-To: <20211215104318.18866-4-tzimmermann@suse.de> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20211215104318.18866-1-tzimmermann@suse.de> <20211215104318.18866-4-tzimmermann@suse.de> Date: Wed, 15 Dec 2021 13:04:00 +0200 Message-ID: <87pmpy3za7.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Wed, 15 Dec 2021, Thomas Zimmermann wrote: > * move DP helper code into dp/ (Jani) I suggested adding the subdirectory, but I'm going to bikeshed the name, which I didn't suggest. $ find drivers/gpu/drm -mindepth 1 -maxdepth 1 -type d | wc -l 68 Assuming we move more of the drm modules to subdirectories, how are they going to stand out from drivers? I suggested drm_dp, which I understand results in tautology, but hey, all the filenames under drm/ also have drm_*.[ch]. And I find that very useful for git greps and other code archeology. With just the dp name, you'd have to know and list all the drm subdirectories when looking up stuff that's part of drm but not drivers. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center