Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B340C433E2 for ; Fri, 4 Sep 2020 19:20:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 58B3A20684 for ; Fri, 4 Sep 2020 19:20:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726842AbgIDTUB convert rfc822-to-8bit (ORCPT ); Fri, 4 Sep 2020 15:20:01 -0400 Received: from albireo.enyo.de ([37.24.231.21]:36510 "EHLO albireo.enyo.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726135AbgIDTUB (ORCPT ); Fri, 4 Sep 2020 15:20:01 -0400 Received: from [172.17.203.2] (helo=deneb.enyo.de) by albireo.enyo.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) id 1kEHFf-0005Q2-Bo; Fri, 04 Sep 2020 19:19:59 +0000 Received: from fw by deneb.enyo.de with local (Exim 4.92) (envelope-from ) id 1kEHFf-0003P6-8r; Fri, 04 Sep 2020 21:19:59 +0200 From: Florian Weimer To: Adalbert =?utf-8?Q?Laz=C4=83r?= Cc: linux-mm@kvack.org, linux-api@vger.kernel.org, Andrew Morton , Alexander Graf , Stefan Hajnoczi , Jerome Glisse , Paolo Bonzini , Mihai =?utf-8?Q?Don=C8=9Bu?= , Mircea Cirjaliu , Andy Lutomirski , Arnd Bergmann , Sargun Dhillon , Aleksa Sarai , Oleg Nesterov , Jann Horn , Kees Cook , Matthew Wilcox , Christian Brauner Subject: Re: [RESEND RFC PATCH 0/5] Remote mapping References: <20200904113116.20648-1-alazar@bitdefender.com> Date: Fri, 04 Sep 2020 21:19:59 +0200 In-Reply-To: <20200904113116.20648-1-alazar@bitdefender.com> ("Adalbert \=\?utf-8\?Q\?Laz\=C4\=83r\=22's\?\= message of "Fri, 4 Sep 2020 14:31:11 +0300") Message-ID: <87pn71gxi8.fsf@mid.deneb.enyo.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-api-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-api@vger.kernel.org * Adalbert Lazăr: >>> - the control plane accepts three ioctls >>> >>> PIDFD_MEM_MAP takes a struct like >>> >>> struct pidfd_mem_map { >>> uint64_t address; >>> off_t offset; >>> off_t size; >>> int flags; >>> int padding[7]; >>> } >>> >>> After this is done, the memory access fd can be mmap-ed at range >>> [offset, >>> offset+size), and it will read memory from range [address, >>> address+size) of the target descriptor. >>> >>> PIDFD_MEM_UNMAP takes a struct like >>> >>> struct pidfd_mem_unmap { >>> off_t offset; >>> off_t size; >>> } >>> >>> and unmaps the corresponding range of course. off_t depends on preprocessor macros (_FILE_OFFSET_BITS), so these types should be uint64_t, too. I'm not sure what the advantage is of returning separate file descriptors, and nit operating directly on the pidfd.