Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E885C0044D for ; Mon, 16 Mar 2020 15:23:33 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EB82E20663 for ; Mon, 16 Mar 2020 15:23:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="eYetZtCn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EB82E20663 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:39582 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jDraV-0003jJ-Ar for qemu-devel@archiver.kernel.org; Mon, 16 Mar 2020 11:23:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43641) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jDqLG-00073j-BN for qemu-devel@nongnu.org; Mon, 16 Mar 2020 10:03:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jDqLF-0004sk-72 for qemu-devel@nongnu.org; Mon, 16 Mar 2020 10:03:42 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:49531 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jDqLF-0004oA-1b for qemu-devel@nongnu.org; Mon, 16 Mar 2020 10:03:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1584367420; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XnLZtjIU8Lbvy5ksQnk5dr0jubYOTU2++eNk5on0R/s=; b=eYetZtCnr2IAWnZTBpcmtP/SBoKYlVNvCGGGbew8Fgt6/cVRVcasY8/zN5ivCmwsQ2XBt4 2csiSdWaKWRL0N5YOOHczSkJ97AvVVeGHomJmmyO4r4YpBJrMb3Cjkp0Zt7VFbmqbqSyFq VNkCM2jubg0eZ1EyB0jbzO/ImsYJHWk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-267-ICNL31ALMn6TCQ8FymRcwg-1; Mon, 16 Mar 2020 10:03:39 -0400 X-MC-Unique: ICNL31ALMn6TCQ8FymRcwg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 70D2A801FAD; Mon, 16 Mar 2020 14:03:37 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-116-49.ams2.redhat.com [10.36.116.49]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3215A60BE2; Mon, 16 Mar 2020 14:03:34 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id B1A601138404; Mon, 16 Mar 2020 15:03:32 +0100 (CET) From: Markus Armbruster To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Subject: Re: [PATCH 6/8] hw/ide: Do ide_drive_get() within pci_ide_create_devs() References: <49bf646a9419c3b20125187a26f8a4fd5f35f399.1584134074.git.balaton@eik.bme.hu> <87d09c3jjj.fsf@dusky.pond.sub.org> Date: Mon, 16 Mar 2020 15:03:32 +0100 In-Reply-To: ("Philippe =?utf-8?Q?Mathieu-Daud=C3=A9=22's?= message of "Mon, 16 Mar 2020 09:30:52 +0100") Message-ID: <87pndcgzwr.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Habkost , qemu-block@nongnu.org, "Michael S. Tsirkin" , Mark Cave-Ayland , Markus Armbruster , qemu-devel@nongnu.org, hpoussin@reactos.org, Aleksandar Markovic , Paolo Bonzini , John Snow , Artyom Tarasenko , Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Philippe Mathieu-Daud=C3=A9 writes: > On 3/16/20 7:23 AM, Markus Armbruster wrote: >> Paolo Bonzini writes: >> >>> On 13/03/20 23:16, BALATON Zoltan wrote: >>>>> >>>>> +=C2=A0=C2=A0=C2=A0 pci_dev =3D pci_create_simple(pci_bus, -1, "cmd64= 6-ide"); >>>>> +=C2=A0=C2=A0=C2=A0 pci_ide_create_devs(pci_dev); >>>> >>>> Additionally, I think it may also make sense to move pci_ide_create_de= vs >>>> call into the realize methods of these IDE controllers so boards do no= t >>>> need to do it explicitely. These calls always follow the creation of t= he >>>> device immediately so could just be done internally in IDE device and >>>> simplify it further. I can attempt to prepare additional patches for >>>> that but first I'd like to hear if anyone has anything against that to >>>> avoid doing useless work. >>> >>> No, it's better to do it separately. I think that otherwise you could >>> add another IDE controller with -device, and both controllers would try >>> to add the drives. >> >> Correct. >> >> Creating device frontends for -drive if=3Dide is the board's job. Board= s >> may delegate to suitable helpers. I'd very much prefer these helpers >> not to live with device model code. Board and device model code should >> be cleanly separated to to reduce the temptation to muddle their >> responsibilities. It's separation of concerns. >> >> I actually wish we had separate sub-trees for boards and devices instead >> of keeping both in hw/. > > Never too late! > > To be clear, you suggest: > > - one dir with machines, boards, system-on-module > - one dir with devices, cpu, system-on-chips > > Correct? In QOM terms: * One sub-tree with descendants of TYPE_DEVICE * One sub-tree with descendants of TYPE_MACHINE