From: Jani Nikula Subject: Re: [PATCH v4 1/2] drm/i915/vbt: Parse panel options separately from timing data Date: Fri, 15 Nov 2019 09:24:53 +0200 Message-ID: <87pnht1u0q.fsf@intel.com> References: <20191114170810.14829-1-matthew.d.roper@intel.com> <20191114170810.14829-2-matthew.d.roper@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8B1596E0BF for ; Fri, 15 Nov 2019 07:24:59 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jesse Barnes , Matt Roper Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCAxNCBOb3YgMjAxOSwgSmVzc2UgQmFybmVzIDxqc2Jhcm5lc0Bnb29nbGUuY29tPiB3 cm90ZToKPiBMR1RNLgo+Cj4gUmV2aWV3ZWQtYnk6IEplc3NlIEJhcm5lcyA8anNiYXJuZXNAZ29v Z2xlLmNvbT4KCllheSEKCkxHVE0gdG9vLgoKPgo+IE9uIFRodSwgTm92IDE0LCAyMDE5IGF0IDk6 MDcgQU0gTWF0dCBSb3BlciA8bWF0dGhldy5kLnJvcGVyQGludGVsLmNvbT4gd3JvdGU6Cj4+Cj4+ IE5ld2VyIFZCVCB2ZXJzaW9ucyB3aWxsIGFkZCBhbiBhbHRlcm5hdGUgd2F5IHRvIHJlYWQgcGFu ZWwgRFRECj4+IGluZm9ybWF0aW9uLCBzbyBsZXQncyBzcGxpdCBwYXJzaW5nIG9mIHRoZSBnZW5l cmFsIHBhbmVsIGluZm9ybWF0aW9uCj4+IGZyb20gdGhlIHRpbWluZyBkYXRhIGluIHByZXBhcmF0 aW9uLgo+Pgo+PiBDYzogSmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGludGVsLmNvbT4KPj4gU2ln bmVkLW9mZi1ieTogTWF0dCBSb3BlciA8bWF0dGhldy5kLnJvcGVyQGludGVsLmNvbT4KPj4gLS0t Cj4+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX2Jpb3MuYyB8IDI3ICsrKysr KysrKysrKysrKy0tLS0tLS0tCj4+ICAxIGZpbGUgY2hhbmdlZCwgMTggaW5zZXJ0aW9ucygrKSwg OSBkZWxldGlvbnMoLSkKPj4KPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rp c3BsYXkvaW50ZWxfYmlvcy5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9i aW9zLmMKPj4gaW5kZXggNmQ3YjFhODNjYjA3Li5kMTNjZTBiN2RiOGIgMTAwNjQ0Cj4+IC0tLSBh L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfYmlvcy5jCj4+ICsrKyBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfYmlvcy5jCj4+IEBAIC0yMDgsMTcgKzIwOCwx MiBAQCBnZXRfbHZkc19mcF90aW1pbmcoY29uc3Qgc3RydWN0IGJkYl9oZWFkZXIgKmJkYiwKPj4g ICAgICAgICByZXR1cm4gKGNvbnN0IHN0cnVjdCBsdmRzX2ZwX3RpbWluZyAqKSgoY29uc3QgdTgg KiliZGIgKyBvZnMpOwo+PiAgfQo+Pgo+PiAtLyogVHJ5IHRvIGZpbmQgaW50ZWdyYXRlZCBwYW5l bCBkYXRhICovCj4+ICsvKiBQYXJzZSBnZW5lcmFsIHBhbmVsIG9wdGlvbnMgKi8KPj4gIHN0YXRp YyB2b2lkCj4+IC1wYXJzZV9sZnBfcGFuZWxfZGF0YShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAq ZGV2X3ByaXYsCj4+IC0gICAgICAgICAgICAgICAgICAgIGNvbnN0IHN0cnVjdCBiZGJfaGVhZGVy ICpiZGIpCj4+ICtwYXJzZV9wYW5lbF9vcHRpb25zKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpk ZXZfcHJpdiwKPj4gKyAgICAgICAgICAgICAgICAgICBjb25zdCBzdHJ1Y3QgYmRiX2hlYWRlciAq YmRiKQo+PiAgewo+PiAgICAgICAgIGNvbnN0IHN0cnVjdCBiZGJfbHZkc19vcHRpb25zICpsdmRz X29wdGlvbnM7Cj4+IC0gICAgICAgY29uc3Qgc3RydWN0IGJkYl9sdmRzX2xmcF9kYXRhICpsdmRz X2xmcF9kYXRhOwo+PiAtICAgICAgIGNvbnN0IHN0cnVjdCBiZGJfbHZkc19sZnBfZGF0YV9wdHJz ICpsdmRzX2xmcF9kYXRhX3B0cnM7Cj4+IC0gICAgICAgY29uc3Qgc3RydWN0IGx2ZHNfZHZvX3Rp bWluZyAqcGFuZWxfZHZvX3RpbWluZzsKPj4gLSAgICAgICBjb25zdCBzdHJ1Y3QgbHZkc19mcF90 aW1pbmcgKmZwX3RpbWluZzsKPj4gLSAgICAgICBzdHJ1Y3QgZHJtX2Rpc3BsYXlfbW9kZSAqcGFu ZWxfZml4ZWRfbW9kZTsKPj4gICAgICAgICBpbnQgcGFuZWxfdHlwZTsKPj4gICAgICAgICBpbnQg ZHJyc19tb2RlOwo+PiAgICAgICAgIGludCByZXQ7Cj4+IEBAIC0yNjcsNiArMjYyLDE5IEBAIHBh cnNlX2xmcF9wYW5lbF9kYXRhKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPj4g ICAgICAgICAgICAgICAgIERSTV9ERUJVR19LTVMoIkRSUlMgbm90IHN1cHBvcnRlZCAoVkJUIGlu cHV0KVxuIik7Cj4+ICAgICAgICAgICAgICAgICBicmVhazsKPj4gICAgICAgICB9Cj4+ICt9Cj4+ ICsKPj4gKy8qIFRyeSB0byBmaW5kIGludGVncmF0ZWQgcGFuZWwgdGltaW5nIGRhdGEgKi8KPj4g K3N0YXRpYyB2b2lkCj4+ICtwYXJzZV9sZnBfcGFuZWxfZHRkKHN0cnVjdCBkcm1faTkxNV9wcml2 YXRlICpkZXZfcHJpdiwKPj4gKyAgICAgICAgICAgICAgICAgICBjb25zdCBzdHJ1Y3QgYmRiX2hl YWRlciAqYmRiKQo+PiArewo+PiArICAgICAgIGNvbnN0IHN0cnVjdCBiZGJfbHZkc19sZnBfZGF0 YSAqbHZkc19sZnBfZGF0YTsKPj4gKyAgICAgICBjb25zdCBzdHJ1Y3QgYmRiX2x2ZHNfbGZwX2Rh dGFfcHRycyAqbHZkc19sZnBfZGF0YV9wdHJzOwo+PiArICAgICAgIGNvbnN0IHN0cnVjdCBsdmRz X2R2b190aW1pbmcgKnBhbmVsX2R2b190aW1pbmc7Cj4+ICsgICAgICAgY29uc3Qgc3RydWN0IGx2 ZHNfZnBfdGltaW5nICpmcF90aW1pbmc7Cj4+ICsgICAgICAgc3RydWN0IGRybV9kaXNwbGF5X21v ZGUgKnBhbmVsX2ZpeGVkX21vZGU7Cj4+ICsgICAgICAgaW50IHBhbmVsX3R5cGUgPSBkZXZfcHJp di0+dmJ0LnBhbmVsX3R5cGU7Cj4+Cj4+ICAgICAgICAgbHZkc19sZnBfZGF0YSA9IGZpbmRfc2Vj dGlvbihiZGIsIEJEQl9MVkRTX0xGUF9EQVRBKTsKPj4gICAgICAgICBpZiAoIWx2ZHNfbGZwX2Rh dGEpCj4+IEBAIC0xODY4LDcgKzE4NzYsOCBAQCB2b2lkIGludGVsX2Jpb3NfaW5pdChzdHJ1Y3Qg ZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4+ICAgICAgICAgLyogR3JhYiB1c2VmdWwgZ2Vu ZXJhbCBkZWZpbml0aW9ucyAqLwo+PiAgICAgICAgIHBhcnNlX2dlbmVyYWxfZmVhdHVyZXMoZGV2 X3ByaXYsIGJkYik7Cj4+ICAgICAgICAgcGFyc2VfZ2VuZXJhbF9kZWZpbml0aW9ucyhkZXZfcHJp diwgYmRiKTsKPj4gLSAgICAgICBwYXJzZV9sZnBfcGFuZWxfZGF0YShkZXZfcHJpdiwgYmRiKTsK Pj4gKyAgICAgICBwYXJzZV9wYW5lbF9vcHRpb25zKGRldl9wcml2LCBiZGIpOwo+PiArICAgICAg IHBhcnNlX2xmcF9wYW5lbF9kdGQoZGV2X3ByaXYsIGJkYik7Cj4+ICAgICAgICAgcGFyc2VfbGZw X2JhY2tsaWdodChkZXZfcHJpdiwgYmRiKTsKPj4gICAgICAgICBwYXJzZV9zZHZvX3BhbmVsX2Rh dGEoZGV2X3ByaXYsIGJkYik7Cj4+ICAgICAgICAgcGFyc2VfZHJpdmVyX2ZlYXR1cmVzKGRldl9w cml2LCBiZGIpOwo+PiAtLQo+PiAyLjIxLjAKPj4KPj4gX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KPj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+PiBJbnRl bC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cj4gX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gSW50ZWwt Z2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4CgotLSAKSmFuaSBOaWt1bGEsIEludGVsIE9wZW4g U291cmNlIEdyYXBoaWNzIENlbnRlcgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9pbnRlbC1nZng=