From: Alex =?utf-8?Q?Benn=C3=A9e?= Subject: Re: [PATCH v2 07/14] KVM: arm64/sve: Make register ioctl access errors more consistent Date: Thu, 25 Apr 2019 16:04:36 +0100 Message-ID: <87pnpaunwb.fsf@zen.linaroharston> References: <1555603631-8107-1-git-send-email-Dave.Martin@arm.com> <1555603631-8107-8-git-send-email-Dave.Martin@arm.com> <877ebiw9lm.fsf@zen.linaroharston> <20190425130424.GA3567@e103592.cambridge.arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-reply-to: <20190425130424.GA3567@e103592.cambridge.arm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Dave Martin Cc: Okamoto Takayuki , Christoffer Dall , Ard Biesheuvel , Marc Zyngier , Catalin Marinas , Will Deacon , Zhang Lei , Julien Grall , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org List-Id: kvmarm@lists.cs.columbia.edu CkRhdmUgTWFydGluIDxEYXZlLk1hcnRpbkBhcm0uY29tPiB3cml0ZXM6Cgo+IE9uIFRodSwgQXBy IDI1LCAyMDE5IGF0IDAxOjMwOjI5UE0gKzAxMDAsIEFsZXggQmVubsOpZSB3cm90ZToKPj4KPj4g RGF2ZSBNYXJ0aW4gPERhdmUuTWFydGluQGFybS5jb20+IHdyaXRlczoKPj4KPj4gPiBDdXJyZW50 bHksIHRoZSB3YXkgZXJyb3IgY29kZXMgYXJlIGdlbmVyYXRlZCB3aGVuIHByb2Nlc3NpbmcgdGhl Cj4+ID4gU1ZFIHJlZ2lzdGVyIGFjY2VzcyBpb2N0bHMgaW4gYSBiaXQgaGFwaGF6YXJkLgo+PiA+ Cj4+ID4gVGhpcyBwYXRjaCByZWZhY3RvcnMgdGhlIGNvZGUgc28gdGhhdCB0aGUgYmVoYXZpb3Vy IGlzIG1vcmUKPj4gPiBjb25zaXN0ZW50OiBub3csIC1FSU5WQUwgc2hvdWxkIGJlIHJldHVybmVk IG9ubHkgZm9yIHVucmVjb2duaXNlZAo+PiA+IHJlZ2lzdGVyIElEcyBvciB3aGVuIHNvbWUgb3Ro ZXIgcnVudGltZSBlcnJvciBvY2N1cnMuICAtRU5PRU5UIGlzCj4+ID4gcmV0dXJuZWQgZm9yIHJl Z2lzdGVyIElEcyB0aGF0IGFyZSByZWNvZ25pc2VkLCBidXQgd2hvc2UKPj4gPiBjb3JyZXNwb25k aW5nIHJlZ2lzdGVyIChvciBzbGljZSkgZG9lcyBub3QgZXhpc3QgZm9yIHRoZSB2Y3B1Lgo+PiA+ Cj4+ID4gVG8gdGhpcyBlbmQsIGluIHtnZXQsc2V0fV9zdmVfcmVnKCkgd2Ugbm93IGRlbGVnYXRl IHRoZQo+PiA+IHZjcHVfaGFzX3N2ZSgpIGNoZWNrIGRvd24gaW50byB7Z2V0LHNldH1fc3ZlX3Zs cygpIGFuZAo+PiA+IHN2ZV9yZWdfdG9fcmVnaW9uKCkuICBUaGUgS1ZNX1JFR19BUk02NF9TVkVf VkxTIHNwZWNpYWwgY2FzZSBpcwo+PiA+IHBpY2tlZCBvZmYgZmlyc3QsIHRoZW4gc3ZlX3JlZ190 b19yZWdpb24oKSBwbGF5cyB0aGUgcm9sZSBvZgo+PiA+IGV4aGF1c3RpdmVseSB2YWxpZGF0aW5n IG9yIHJlamVjdGluZyB0aGUgcmVnaXN0ZXIgSUQgYW5kICh3aGVyZQo+PiA+IGFjY2VwdGVkKSBj b21wdXRpbmcgdGhlIGFwcGxpY2FibGUgcmVnaXN0ZXIgcmVnaW9uIGFzIGJlZm9yZS4KPj4gPgo+ PiA+IHN2ZV9yZWdfdG9fcmVnaW9uKCkgaXMgcmVhcnJhbmdlZCBzbyB0aGF0IC1FTk9FTlQgb3Ig LUVQRVJNIGlzIG5vdAo+PiA+IHJldHVybmVkIHByZW1hdHVyZWx5LCBiZWZvcmUgY2hlY2tpbmcg d2hldGhlciByZWctPmlkIGlzIGluIGEKPj4gPiByZWNvZ25pc2VkIHJhbmdlLgo+PiA+Cj4+ID4g LUVQRVJNIGlzIG5vdyBvbmx5IHJldHVybmVkIHdoZW4gYW4gYXR0ZW1wdCBpcyBtYWRlIHRvIGFj Y2VzcyBhbgo+PiA+IGFjdHVhbGx5IGV4aXN0aW5nIHJlZ2lzdGVyIHNsaWNlIG9uIGFuIHVuZmlu YWxpemVkIHZjcHUuCj4+ID4KPj4gPiBGaXhlczogZTFjOWM5ODM0NWIzICgiS1ZNOiBhcm02NC9z dmU6IEFkZCBTVkUgc3VwcG9ydCB0byByZWdpc3RlciBhY2Nlc3MgaW9jdGwgaW50ZXJmYWNlIikK Pj4gPiBGaXhlczogOTAzM2JiYTRiNTM1ICgiS1ZNOiBhcm02NC9zdmU6IEFkZCBwc2V1ZG8tcmVn aXN0ZXIgZm9yIHRoZSBndWVzdCdzIHZlY3RvciBsZW5ndGhzIikKPj4gPiBTdWdnZXN0ZWQtYnk6 IEFuZHJldyBKb25lcyA8ZHJqb25lc0ByZWRoYXQuY29tPgo+PiA+IFNpZ25lZC1vZmYtYnk6IERh dmUgTWFydGluIDxEYXZlLk1hcnRpbkBhcm0uY29tPgo+PiA+IFJldmlld2VkLWJ5OiBBbmRyZXcg Sm9uZXMgPGRyam9uZXNAcmVkaGF0LmNvbT4KPgo+IFsuLi5dCj4KPj4gPiBAQCAtMzM1LDI1ICsz NDQsMzAgQEAgc3RhdGljIGludCBzdmVfcmVnX3RvX3JlZ2lvbihzdHJ1Y3Qgc3ZlX3N0YXRlX3Jl Z19yZWdpb24gKnJlZ2lvbiwKPj4gPiAgCS8qIFZlcmlmeSB0aGF0IHdlIG1hdGNoIHRoZSBVQVBJ IGhlYWRlcjogKi8KPj4gPiAgCUJVSUxEX0JVR19PTihTVkVfTlVNX1NMSUNFUyAhPSBLVk1fQVJN NjRfU1ZFX01BWF9TTElDRVMpOwo+PiA+Cj4+ID4gLQlpZiAoKHJlZy0+aWQgJiBTVkVfUkVHX1NM SUNFX01BU0spID4gMCkKPj4gPiAtCQlyZXR1cm4gLUVOT0VOVDsKPj4gPiAtCj4+ID4gLQl2cSA9 IHN2ZV92cV9mcm9tX3ZsKHZjcHUtPmFyY2guc3ZlX21heF92bCk7Cj4+ID4gLQo+PiA+ICAJcmVn X251bSA9IChyZWctPmlkICYgU1ZFX1JFR19JRF9NQVNLKSA+PiBTVkVfUkVHX0lEX1NISUZUOwo+ PiA+Cj4+ID4gIAlpZiAocmVnLT5pZCA+PSB6cmVnX2lkX21pbiAmJiByZWctPmlkIDw9IHpyZWdf aWRfbWF4KSB7Cj4+ID4gKwkJaWYgKCF2Y3B1X2hhc19zdmUodmNwdSkgfHwgKHJlZy0+aWQgJiBT VkVfUkVHX1NMSUNFX01BU0spID4gMCkKPj4gPiArCQkJcmV0dXJuIC1FTk9FTlQ7Cj4+ID4gKwo+ PiA+ICsJCXZxID0gc3ZlX3ZxX2Zyb21fdmwodmNwdS0+YXJjaC5zdmVfbWF4X3ZsKTsKPj4gPiAr Cj4+ID4gIAkJcmVxb2Zmc2V0ID0gU1ZFX1NJR19aUkVHX09GRlNFVCh2cSwgcmVnX251bSkgLQo+ PiA+ICAJCQkJU1ZFX1NJR19SRUdTX09GRlNFVDsKPj4gPiAgCQlyZXFsZW4gPSBLVk1fU1ZFX1pS RUdfU0laRTsKPj4gPiAgCQltYXhsZW4gPSBTVkVfU0lHX1pSRUdfU0laRSh2cSk7Cj4+ID4gIAl9 IGVsc2UgaWYgKHJlZy0+aWQgPj0gcHJlZ19pZF9taW4gJiYgcmVnLT5pZCA8PSBwcmVnX2lkX21h eCkgewo+PiA+ICsJCWlmICghdmNwdV9oYXNfc3ZlKHZjcHUpIHx8IChyZWctPmlkICYgU1ZFX1JF R19TTElDRV9NQVNLKSA+IDApCj4+ID4gKwkJCXJldHVybiAtRU5PRU5UOwo+PiA+ICsKPj4gPiAr CQl2cSA9IHN2ZV92cV9mcm9tX3ZsKHZjcHUtPmFyY2guc3ZlX21heF92bCk7Cj4+ID4gKwo+Pgo+ PiBJIHN1cHBvc2UgeW91IGNvdWxkIGFyZ3VlIGZvciBhOgo+Pgo+PiAJaWYgKHJlZy0+aWQgPj0g enJlZ19pZF9taW4gJiYgcmVnLT5pZCA8PSBwcmVnX2lkX21heCkgewo+PiAJCWlmICghdmNwdV9o YXNfc3ZlKHZjcHUpIHx8IChyZWctPmlkICYgU1ZFX1JFR19TTElDRV9NQVNLKSA+IDApCj4+IAkJ CXJldHVybiAtRU5PRU5UOwo+Pgo+PiAJCXZxID0gc3ZlX3ZxX2Zyb21fdmwodmNwdS0+YXJjaC5z dmVfbWF4X3ZsKTsKPj4KPj4gICAgICAgICAgICAgICAgIGlmIChyZWctPmlkIDw9IHpyZWdfaWRf bWF4KSB7Cj4+IAkJCXJlcW9mZnNldCA9IFNWRV9TSUdfWlJFR19PRkZTRVQodnEsIHJlZ19udW0p IC0KPj4gCQkJCVNWRV9TSUdfUkVHU19PRkZTRVQ7Cj4+IAkJCXJlcWxlbiA9IEtWTV9TVkVfWlJF R19TSVpFOwo+PiAJCQltYXhsZW4gPSBTVkVfU0lHX1pSRUdfU0laRSh2cSk7Cj4+ICAgICAgICAg ICAgICAgICB9IGVsc2Ugewo+PiAJCQlyZXFvZmZzZXQgPSBTVkVfU0lHX1BSRUdfT0ZGU0VUKHZx LCByZWdfbnVtKSAtCj4+IAkJCQlTVkVfU0lHX1JFR1NfT0ZGU0VUOwo+PiAJCQlyZXFsZW4gPSBL Vk1fU1ZFX1BSRUdfU0laRTsKPj4gCQkJbWF4bGVuID0gU1ZFX1NJR19QUkVHX1NJWkUodnEpOwo+ PiAJCX0KPj4gCX0gZWxzZSB7Cj4+IAkJcmV0dXJuIC1FSU5WQUw7Cj4+IAl9Cj4+Cj4+IGJ1dCBv bmx5IGZvciBtaW5pbWFsIERSWSByZWFzb25zLgo+Cj4gQWdyZWVkLCBidXQgdGhhdCBiYWtlcyBp biBhbm90aGVyIGFzc3VtcHRpb246IHRoYXQgdGhlIFpSRUcgYW5kIFBSRUcgSUQKPiByYW5nZXMg YXJlIGNvbnRpZ3VvdXMuCgpBaGggSSdkIG1pc3JlYWQ6CgogIC8qIHJlZyBJRCByYW5nZXMgZm9y IFAtIHJlZ2lzdGVycyBhbmQgRkZSICh3aGljaCBhcmUgY29udGlndW91cykgKi8KCkhvd2V2ZXIg dGhlc2UgYXJlIGRlZmluZWQgaW4gdGhlIFVBQkk6CgogIC8qIFotIGFuZCBQLXJlZ3Mgb2NjdXB5 IGJsb2NrcyBhdCB0aGUgZm9sbG93aW5nIG9mZnNldHMgd2l0aGluIHRoaXMgcmFuZ2U6ICovCiAg I2RlZmluZSBLVk1fUkVHX0FSTTY0X1NWRV9aUkVHX0JBU0UJMAogICNkZWZpbmUgS1ZNX1JFR19B Uk02NF9TVkVfUFJFR19CQVNFCTB4NDAwCiAgI2RlZmluZSBLVk1fUkVHX0FSTTY0X1NWRV9GRlJf QkFTRQkweDYwMAoKc28gdGhlcmUgcG9zaXRpb24gaXMgcHJldHR5IGZpeGVkIG5vdyByaWdodD8K Cj4gSSBwcmVmZXJyZWQgdG8ga2VlcCB0aGUgbnVtYmVyIG9mIGFzc3VtcHRpb25zIGRvd24uCj4K PiBBbHRob3VnIHRoZSByZXN1bHRpbmcgY29kZSB3YXNuJ3QgaWRlYWwsIHRoZSBhY3R1YWwgYW1v dW50IG9mCj4gZHVwbGljYXRpb24gdGhhdCBJIGVuZGVkIHVwIHdpdGggaGVyZSBzZWVtZWQgbG93 IGVub3VnaCBhcyB0byBiZQo+IGFjY2VwdGFibGUgKHRob3VnaCBvcGluaW9ucyBjYW4gZGlmZmVy IG9uIHRoYXQpLgoKSXQncyBubyBiaWdnaWUgOy0pCgotLQpBbGV4IEJlbm7DqWUKCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwg bWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8v bGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK