Return-Path: Received: from mail.parknet.co.jp ([210.171.160.6]:54133 "EHLO mail.parknet.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752006AbbKYVwp (ORCPT ); Wed, 25 Nov 2015 16:52:45 -0500 From: OGAWA Hirofumi To: Volker Kuhlmann Cc: Jan Kara , linux-fsdevel@vger.kernel.org Subject: Re: [PATCH] fat: Allow time_offset to be upto 13 hours References: <1448466133-2838-1-git-send-email-jack@suse.cz> <87wpt60w17.fsf@mail.parknet.co.jp> <13558026.NkMQpNgYP2@tui.site> Date: Thu, 26 Nov 2015 06:52:37 +0900 In-Reply-To: <13558026.NkMQpNgYP2@tui.site> (Volker Kuhlmann's message of "Thu, 26 Nov 2015 09:22:24 +1300") Message-ID: <87poyx21cq.fsf@mail.parknet.co.jp> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Volker Kuhlmann writes: >> But I'm not sure why 13? > > It's the minimum that is absolutely required to cover the DST offset in > New Zealand. At the moment. There may be other places around the date > line for which even that is not sufficient. Someone's been thoughtless > already (has happened regularly for decades, probably won't be the last > time either). Fix it properly. > > If the kernel uses +-24 in places then please stick to +-24. There may > be a reason for that not everyone knows about. The purpose of the range > check is to be a SANITY check, not to tell me, the user, how I have to > operate my system. If I want 3 minutes, I want 3 minutes, and it's not > the kernel programmer's job to enforce. > > Or do you wish to track the legal time zone AND DST offsets in every > place in the world, make a list, stick that into the kernel, and > maintain it? I hope not. Actually, it is correct timezone support (for example, daylight). > A good limit would be 2 less of whatever fits into 8 bit. Or something > like that. Like +-120. I'm not against to change. But don't want to change this multiple times, and step by step. It is why I'm asking. Well so, how does it overs 24 hours (i.e. a day) for sane tz offset (implementation is just a dumb adjustment of timestamp, but this option should means tz offset)? (And +-24 hours is used for TZ spec too.) Thanks. -- OGAWA Hirofumi