Received: from eggs.gnu.org ([2001:4830:134:3::10]:41369) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZmW3o-0003Xt-6J for qemu-devel@nongnu.org; Wed, 14 Oct 2015 20:06:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZmW3k-0003Ij-Va for qemu-devel@nongnu.org; Wed, 14 Oct 2015 20:06:20 -0400 Received: from mail.parknet.co.jp ([210.171.160.6]:48083) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZmW3k-0003Id-Lh for qemu-devel@nongnu.org; Wed, 14 Oct 2015 20:06:16 -0400 From: OGAWA Hirofumi References: <87k2qp8yxv.fsf@mail.parknet.co.jp> <87fv1d8ywp.fsf@mail.parknet.co.jp> <87bnc18yvw.fsf_-_@mail.parknet.co.jp> <1444837495.4467.29.camel@redhat.com> <87y4f56lzu.fsf@mail.parknet.co.jp> Date: Thu, 15 Oct 2015 09:06:12 +0900 In-Reply-To: <87y4f56lzu.fsf@mail.parknet.co.jp> (OGAWA Hirofumi's message of "Thu, 15 Oct 2015 08:58:29 +0900") Message-ID: <87pp0h6lmz.fsf@mail.parknet.co.jp> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org OGAWA Hirofumi writes: > Gerd Hoffmann writes: > >> On Mi, 2015-10-14 at 20:37 +0900, OGAWA Hirofumi wrote: >>> This converts vga code to curses code in console_write_bh(). >>> >>> With this changes, we can see line graphics (for example, dialog uses) >>> correctly. >> >> But it breaks line graphics in vga text mode on gtk I suspect? > > vga_to_curses[] is filled by curses_setup(). So if no -curses option, I > think it should have no change to behavior. (BTW, there is no common > section like kernel in qemu build, right? i.e. no need initializer to > global value.) The patch is following reply removes unnecessary memset(vga_to_curses, 0, sizeof(vga_to_curses)); in curses_setup(). And tested line graphics works on both of gtk and curses. Thanks. -- OGAWA Hirofumi