Return-Path: From: Namhyung Kim To: Ingo Molnar Cc: Arnaldo Carvalho de Melo , Peter Zijlstra , Paul Mackerras , Namhyung Kim , LKML , Jiri Olsa , Adrian Hunter , David Ahern , Stephane Eranian , Andi Kleen , stable@vger.kernel.org Subject: Re: [PATCH v3] perf tools: Fix build-id matching on vmlinux References: <1411353945-16576-1-git-send-email-namhyung@kernel.org> <20140922051630.GA18588@gmail.com> Date: Mon, 22 Sep 2014 16:31:49 +0900 In-Reply-To: <20140922051630.GA18588@gmail.com> (Ingo Molnar's message of "Mon, 22 Sep 2014 07:16:30 +0200") Message-ID: <87ppeokt5m.fsf@sejong.aot.lge.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: Hi Ingo, On Mon, 22 Sep 2014 07:16:30 +0200, Ingo Molnar wrote: > * Namhyung Kim wrote: >> + list_for_each_entry(dso, &machine->kernel_dsos, node) { >> + const char *suffix; >> + >> + suffix = dso->long_name + strlen(dso->long_name) - 3; >> + if (strcmp(suffix, ".ko")) { >> + kernel = dso; >> + break; >> + } > > Is strlen(dso->long_name) guaranteed to be >= 3? If not then you > should probably check for it, otherwise we might strcmp into > invalid memory. I *think* they are all valid kernel modules so length should be greater than 3. But I also think that adding such an extra check won't cause any harm. So I'll change to check it in v4. :) Thanks for your review! Namhyung