Received: from eggs.gnu.org ([2001:4830:134:3::10]:41250) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VQg90-0003l4-9a for qemu-devel@nongnu.org; Mon, 30 Sep 2013 12:16:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VQg8v-0005UU-55 for qemu-devel@nongnu.org; Mon, 30 Sep 2013 12:16:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:25433) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VQg8u-0005UG-SV for qemu-devel@nongnu.org; Mon, 30 Sep 2013 12:16:17 -0400 From: Markus Armbruster References: <1380452123-5989-1-git-send-email-mst@redhat.com> <1380452123-5989-2-git-send-email-mst@redhat.com> <20130930151056.32699e7f@nial.usersys.redhat.com> <20130930144050.GB22806@redhat.com> <20130930155044.GA10306@redhat.com> <52499F06.20903@suse.de> Date: Mon, 30 Sep 2013 18:16:11 +0200 In-Reply-To: <52499F06.20903@suse.de> ("Andreas =?utf-8?Q?F=C3=A4rber=22's?= message of "Mon, 30 Sep 2013 17:55:50 +0200") Message-ID: <87pprqxp2s.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v6 01/26] qemu: add Error to typedefs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?utf-8?Q?F=C3=A4rber?= Cc: Peter Maydell , "Michael S. Tsirkin" , QEMU Developers , Gerd Hoffmann , Paolo Bonzini , Igor Mammedov Andreas F=C3=A4rber writes: > Am 30.09.2013 17:50, schrieb Michael S. Tsirkin: >> On Tue, Oct 01, 2013 at 12:10:52AM +0900, Peter Maydell wrote: >>> On 30 September 2013 23:40, Michael S. Tsirkin wrote: >>>> diff --git a/include/qapi/error.h b/include/qapi/error.h >>>> index 7d4c696..b85e996 100644 >>>> --- a/include/qapi/error.h >>>> +++ b/include/qapi/error.h >>>> @@ -13,14 +13,15 @@ >>>> #define ERROR_H >>>> >>>> #include "qemu/compiler.h" >>>> +#include "qemu/typedefs.h" >>>> #include "qapi-types.h" >>>> #include >>>> >>>> /** >>>> - * A class representing internal errors within QEMU. An error has a = ErrorClass >>>> + * Error: >>>> + * An object representing internal errors within QEMU. An error has = a ErrorClass >>>> * code and a human message. >>>> */ >>>> -typedef struct Error Error; >>> >>> Does the process-doc-comments tool really cope with documentation comme= nts >>> that are completely separate from the typedef like this? >>> >>> thanks >>> -- PMM >>=20 >> Do we care? >> Downstreams don't seem to package it, most people probably use >> editor tags anyway ... >> If yes we can put this all in #if 0. > > Can we turn the typedef into just struct Error here? The doc comment can > be applied to either. Yes, please.