Received: from eggs.gnu.org ([208.118.235.92]:53098) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UT6fO-0005Pj-Lh for qemu-devel@nongnu.org; Fri, 19 Apr 2013 04:27:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UT6fL-00068D-Rd for qemu-devel@nongnu.org; Fri, 19 Apr 2013 04:27:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:17502) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UT6fL-00067u-Hn for qemu-devel@nongnu.org; Fri, 19 Apr 2013 04:27:31 -0400 From: Markus Armbruster References: <41b83b75f11879953c8951654321b4ce5a4e2132.1366250561.git.hutao@cn.fujitsu.com> <87ppxsgplb.fsf@blackfin.pond.sub.org> <20130419065051.GI11385@localhost.localdomain> Date: Fri, 19 Apr 2013 10:27:10 +0200 In-Reply-To: <20130419065051.GI11385@localhost.localdomain> (Hu Tao's message of "Fri, 19 Apr 2013 14:50:51 +0800") Message-ID: <87ppxrncwx.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v19 4/7] pvpanic: pass configurable ioport to seabios List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hu Tao Cc: Marcelo Tosatti , Peter Maydell , Andrew Jones , Anthony Liguori , Alex Williamson , Gleb Natapov , "Michael S. Tsirkin" , Jan Kiszka , Juan Quintela , qemu-devel , Luiz Capitulino , Blue Swirl , Orit Wasserman , Alexander Graf , Sasha Levin , Stefan Hajnoczi , Paolo Bonzini , Christian Borntraeger , KAMEZAWA Hiroyuki Hu Tao writes: > On Thu, Apr 18, 2013 at 11:22:56AM +0200, Markus Armbruster wrote: >> Hu Tao writes: >>=20 >> > This lets seabios patch the corresponding SSDT entry. [...] >> > diff --git a/include/hw/nvram/fw_cfg.h b/include/hw/nvram/fw_cfg.h >> > index 05c8df1..07cc941 100644 >> > --- a/include/hw/nvram/fw_cfg.h >> > +++ b/include/hw/nvram/fw_cfg.h >> > @@ -1,6 +1,8 @@ >> > #ifndef FW_CFG_H >> > #define FW_CFG_H >> >=20=20 >> > +#include "exec/hwaddr.h" >> > + >> > #define FW_CFG_SIGNATURE 0x00 >> > #define FW_CFG_ID 0x01 >> > #define FW_CFG_UUID 0x02 >>=20 >> Why is the include necessary? > > Withou it gcc gives error like this: > > In file included from hw/misc/pvpanic.c:21:0: > qemu/include/hw/nvram/fw_cfg.h:68:25: error: unknown type name =E2=80=98h= waddr=E2=80=99 > qemu/include/hw/nvram/fw_cfg.h:68:42: error: unknown type name =E2=80=98h= waddr=E2=80=99 Okay, your change makes sense, but it doesn't belong into this patch. Put it into a separate one if you need to respin anyway.