From: OGAWA Hirofumi Subject: Re: [PATCH 2/2] vfs: Fix refcnt leak with __do_follow_link() in do_filp_open() Date: Thu, 14 Jan 2010 12:32:49 +0900 Message-ID: <87pr5dfjj2.fsf@devron.myhome.or.jp> References: <87vdf8jxug.fsf@devron.myhome.or.jp> <87r5pwjxr2.fsf@devron.myhome.or.jp> <20100113195059.GC4673@ZenIV.linux.org.uk> <20100113200711.GD19799@ZenIV.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org To: Al Viro Return-path: Received: from mail.parknet.co.jp ([210.171.160.6]:48344 "EHLO mail.parknet.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751115Ab0ANDcw (ORCPT ); Wed, 13 Jan 2010 22:32:52 -0500 In-Reply-To: <20100113200711.GD19799@ZenIV.linux.org.uk> (Al Viro's message of "Wed, 13 Jan 2010 20:07:11 +0000") Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Al Viro writes: > On Wed, Jan 13, 2010 at 07:51:00PM +0000, Al Viro wrote: > >> Point, but... that's not the way I'd do it (again, see #untested for the >> direction it's heading). What we ought to do is simply "put ourselves >> in trust-no-one mode (LOOKUP_REVAL) and restart the entire thing; if >> we'd already been through that, fail immediately". >> >> And yes, it needs to be pulled in front of queue and go in before .34. >> Will do shortly. > > See commit 1fe1244faf0e862342bd2ae29e341cc957469aee in vfs-2.6.git#for-linus > (that's going to be rc5 fixes push tonight, after several more things get > shifted there). Thanks. I'll see later. -- OGAWA Hirofumi