Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MGx61-0008NB-6Z for qemu-devel@nongnu.org; Wed, 17 Jun 2009 11:30:41 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MGx5w-00086S-2C for qemu-devel@nongnu.org; Wed, 17 Jun 2009 11:30:40 -0400 Received: from [199.232.76.173] (port=40991 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MGx5v-000869-VC for qemu-devel@nongnu.org; Wed, 17 Jun 2009 11:30:35 -0400 Received: from mx2.redhat.com ([66.187.237.31]:44880) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MGx5v-0003zE-DM for qemu-devel@nongnu.org; Wed, 17 Jun 2009 11:30:35 -0400 Subject: Re: [Qemu-devel] [PATCH] bios: Fix multiple calls into smbios_load_external() References: <1243528568.25164.47.camel@bling> From: Markus Armbruster Date: Wed, 17 Jun 2009 17:30:24 +0200 In-Reply-To: <1243528568.25164.47.camel@bling> (Alex Williamson's message of "Thu\, 28 May 2009 10\:36\:07 -0600") Message-ID: <87prd27u9b.fsf@pike.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex Williamson Cc: bochs-developers , Beth Kon , qemu-devel Alex Williamson writes: > We're marking the used entry bitmap in smbios_load_external() for each > type we check, regardless of whether we loaded anything. This makes > subsequent calls behave as if we've already loaded the tables from qemu > and can result in missing tables (ex. multiple type4 entries on an SMP > guest). Only mark the bitmap if we actually load something. > > Signed-off-by: Alex Williamson > -- For what it's worth, I got bitten by this bug (one of two CPUs missing from dmidecode), and the patch fixes it.