From: OGAWA Hirofumi Subject: Re: Mount ext3 with barrier=1 doesn't send real barrier bio? Date: Fri, 22 Aug 2008 16:45:54 +0900 Message-ID: <87pro1xzkd.fsf@devron.myhome.or.jp> References: <48A5F5C6.2090204@redhat.com> <48ACAADD.2010104@sandeen.net> <874p5eqa6h.fsf@devron.myhome.or.jp> <20080822063823.GR20055@kernel.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Eric Sandeen , Milan Broz , Linux Kernel Mailing List , linux-fsdevel , Ric Wheeler , "MASON\,CHRISTOPHER" To: Jens Axboe Return-path: Received: from mail.parknet.ad.jp ([210.171.162.6]:36401 "EHLO mail.officemail.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752462AbYHVHqA (ORCPT ); Fri, 22 Aug 2008 03:46:00 -0400 In-Reply-To: <20080822063823.GR20055@kernel.dk> (Jens Axboe's message of "Fri, 22 Aug 2008 08:38:24 +0200") Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Jens Axboe writes: >> This should be ((rw & RW_MASK) == WRITE) too? Anyway, this seems change >> behavior of submit_bh(WRITE_BARRIER) (maybe reiserfs only), it wouldn't >> be your intent... > > Yes, I believe the simpler and more correct fix is: > > diff --git a/fs/buffer.c b/fs/buffer.c > index 38653e3..16b2263 100644 > --- a/fs/buffer.c > +++ b/fs/buffer.c > @@ -2926,14 +2926,13 @@ int submit_bh(int rw, struct buffer_head * bh) > BUG_ON(!buffer_mapped(bh)); > BUG_ON(!bh->b_end_io); > > - if (buffer_ordered(bh) && (rw == WRITE)) > + if (buffer_ordered(bh) && (rw & WRITE)) > rw = WRITE_BARRIER; I see. But, umm..., this means WRITE_SYNC with barrier was deprecated? Or typo? -- OGAWA Hirofumi