Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 591FF6775E for ; Tue, 30 Jan 2024 12:12:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706616753; cv=none; b=kE6WJ4HCfgjESkvFAoAd3936GfqAJGIlGge31zBELtysNjz6KRtQmtJ+3WOz+sXosAakgz2kEY36+nvV4Lc6hV3xqeZ64Lgcz3Q61FttjwXYn5zcnmakDh+6Zc5/lxnNGMu0jdQIjOSO+UIPUSPNQgCfUNfc1FtRIzyDSGpCK3E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706616753; c=relaxed/simple; bh=qtKz5PUT9mkDsa8isUg58tbqJCm6B3Touj9jntprnT4=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=A7Vavqz+Gu4AxN7xkfrbHAE3rxO60obx8jYf1gv36EpEUfXsGHTW6sTuj7YL7JK57DBQU9FuXX6hlQeX6tV1Gz7+b5kZINl0twMayb/O9n3o+Lq/0FBL+5/gg9wG2/Psdu25AUFMpNsJMKK1t6A//REwnAlcjDg008/VSW8fUuI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=NrqOuS07; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="NrqOuS07" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B8A53C433C7; Tue, 30 Jan 2024 12:12:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706616752; bh=qtKz5PUT9mkDsa8isUg58tbqJCm6B3Touj9jntprnT4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=NrqOuS07Jp2W7AUAgmBUQS096hW0Wbl+CnPwYM84PTwAZdzKD8I1rbgt+6OAUApYi X++8FSbNCtMxVh5DGwzItWhRNGutrz5Ot/qZ5zb8TEveu8nLCvHVvYXMUkFifN2ecQ J0fDpcEE8xAzh28C4zzhLhOnHgogvrVB5sa6WXK9QPs8tokxVY37yffWeoKqtJ34u3 Rz9RHyEcx9lQNHU4KEt1OQPyVyxI73NN1Rpbgr0XcGQ4NWiIAld+IKAa3J4NYTrw4E w93sGxxfkPW81wwZEsjtpTpDpOavvv2DFxd2KnYAD/fPgacxWMMKnD9Wvg+LsPg9hU wX1pLKyPSAhvQ== Received: from [12.161.88.66] (helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rUmyc-00GFWy-Cu; Tue, 30 Jan 2024 12:12:30 +0000 Date: Tue, 30 Jan 2024 12:12:26 +0000 Message-ID: <87r0hzvx3p.wl-maz@kernel.org> From: Marc Zyngier To: Oliver Upton Cc: kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, James Morse , Suzuki K Poulose , Zenghui Yu , Catalin Marinas , Will Deacon , Joey Gouly , Mark Brown Subject: Re: [PATCH 02/25] KVM: arm64: Add feature checking helpers In-Reply-To: References: <20240122201852.262057-1-maz@kernel.org> <20240122201852.262057-3-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 12.161.88.66 X-SA-Exim-Rcpt-To: oliver.upton@linux.dev, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, catalin.marinas@arm.com, will@kernel.org, joey.gouly@arm.com, broonie@kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Fri, 26 Jan 2024 19:05:47 +0000, Oliver Upton wrote: > > On Mon, Jan 22, 2024 at 08:18:29PM +0000, Marc Zyngier wrote: > > In order to make it easier to check whether a particular feature > > is exposed to a guest, add a new set of helpers, with kvm_has_feat() > > being the most useful. > > > > Follow-up work will make heavy use of these. > > > > Signed-off-by: Marc Zyngier > > I very much like the way these helpers appear to work. However, I > noticed there are still a few places where we are doing explicit feature > checks against register values instead of using the macros, did you want > to address these? Eventually, yes. It is just that there is a lot to do and I wanted to focus on the VM runtime configuration. > > Using kvm_has_feat() consistently in KVM will hopefully drive the point > home that this is the way we want to see things done going forward. Absolutely. I'll add these to the series. Thanks! M. -- Without deviation from the norm, progress is not possible.