Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EA50C2D0E0 for ; Tue, 15 Sep 2020 06:28:23 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0B7772076C for ; Tue, 15 Sep 2020 06:28:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Y9U1uoaz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0B7772076C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:38022 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kI4Ry-0005UT-6u for qemu-devel@archiver.kernel.org; Tue, 15 Sep 2020 02:28:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54570) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kI4RG-0004pl-VP for qemu-devel@nongnu.org; Tue, 15 Sep 2020 02:27:38 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:33879) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kI4RF-0005bh-Ct for qemu-devel@nongnu.org; Tue, 15 Sep 2020 02:27:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600151256; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=I8AdB452kff1INhzPkhLt6QoWlRLjwwjHZvHrNxQULo=; b=Y9U1uoazxuJaa6oFxEnu539ZYUUh7NNhdfqe4Z/unBr4vyeL+rQJrLWm2Z4wvDmUiwUAQU MjYp9KvK2TKb0DimX4mA/liQAFfYB999CrAr+PsKbgnOZ5gcPY5poHCUlDny26BgPj8lIQ ymsKVJGx1XunAPofEn4FtY+tuEPgoK8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-328-oes8mQ--PmaUplEJl72Sgg-1; Tue, 15 Sep 2020 02:27:32 -0400 X-MC-Unique: oes8mQ--PmaUplEJl72Sgg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A34611007460; Tue, 15 Sep 2020 06:27:31 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-114-66.ams2.redhat.com [10.36.114.66]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6679E10021AA; Tue, 15 Sep 2020 06:27:31 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id D95E5113864A; Tue, 15 Sep 2020 08:27:29 +0200 (CEST) From: Markus Armbruster To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Subject: Re: [PATCH v5 1/8] qapi: Restrict LostTickPolicy enum to machine code References: <20200913195348.1064154-1-philmd@redhat.com> <20200913195348.1064154-2-philmd@redhat.com> <871rj4u3ct.fsf@dusky.pond.sub.org> Date: Tue, 15 Sep 2020 08:27:29 +0200 In-Reply-To: ("Philippe =?utf-8?Q?Mathieu-Daud=C3=A9=22's?= message of "Mon, 14 Sep 2020 11:37:07 +0200") Message-ID: <87r1r3imge.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=63.128.21.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/15 02:23:19 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -38 X-Spam_score: -3.9 X-Spam_bar: --- X-Spam_report: (-3.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.792, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , qemu-devel@nongnu.org, Qemu-block , Laurent Vivier Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Philippe Mathieu-Daud=C3=A9 writes: > +Laurent + qemu-block@ > > On 9/14/20 11:14 AM, Markus Armbruster wrote: >> Philippe Mathieu-Daud=C3=A9 writes: >>=20 >>> Acked-by: Markus Armbruster >>> Acked-by: Paolo Bonzini >>> Signed-off-by: Philippe Mathieu-Daud=C3=A9 >>=20 >> Unlike the other patches that move code out of misc.json, this one >> doesn't say "allows pulling less declarations/definitions to user-mode." >> Intentional? > > TBH I don't remember as this is 6months old. > > IIUC the "tick lost" feature is only meaningful when running > virtualized with a RTC profile, so this is pointless for > user-mode binaries and tools. Your reply to my question on PATCH 3 "What exactly is being pulled where before the series, and no more afterwards?" leads me to believe this patch is no different. Suggest to add the same rationale to this commit message.