Received: from eggs.gnu.org ([2001:4830:134:3::10]:38955) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9rdS-0007Co-I8 for qemu-devel@nongnu.org; Fri, 18 Dec 2015 04:47:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a9rdO-0002ga-C5 for qemu-devel@nongnu.org; Fri, 18 Dec 2015 04:47:38 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44366) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9rdO-0002gT-76 for qemu-devel@nongnu.org; Fri, 18 Dec 2015 04:47:34 -0500 From: Markus Armbruster References: <1450371004-26866-1-git-send-email-armbru@redhat.com> <1450371004-26866-17-git-send-email-armbru@redhat.com> <567321A1.3070808@redhat.com> Date: Fri, 18 Dec 2015 10:47:30 +0100 In-Reply-To: <567321A1.3070808@redhat.com> (Eric Blake's message of "Thu, 17 Dec 2015 13:57:05 -0700") Message-ID: <87r3ikhyvh.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v2 16/23] error: Strip trailing '\n' from error string arguments (again) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Fam Zheng , zhanghailiang , Stefan Berger , Pavel Fedin , qemu-devel@nongnu.org, Dominik Dingel , "Dr. David Alan Gilbert" , David Hildenbrand , Peter Crosthwaite , "Jason J. Herne" , Bharata B Rao , Changchun Ouyang Eric Blake writes: > On 12/17/2015 09:49 AM, Markus Armbruster wrote: >> Commit 6daf194d, be62a2eb and 312fd5f got rid of a bunch, but they >> keep coming back. Tracked down with the Coccinelle semantic patch >> from commit 312fd5f. > > Don't forget to rerun this to pick up stragglers exposed by 1/23 :) Just two: qemu-nbd.c:574:76:"Shared device number must be greater than 0\n" qemu-nbd.c:557:61:"socket path must be absolute\n" >> Signed-off-by: Markus Armbruster >> Reviewed-by: Dr. David Alan Gilbert >> Acked-by: Cornelia Huck >> Acked-by: Bharata B Rao >> Acked-by: Fam Zheng > > If you want to add to the list: > Reviewed-by: Eric Blake > >> +++ b/hw/s390x/s390-skeys.c >> @@ -191,8 +191,8 @@ static int qemu_s390_skeys_set(S390SKeysState *ss, uint64_t start_gfn, >> /* Check for uint64 overflow and access beyond end of key data */ >> if (start_gfn + count > skeydev->key_count || start_gfn + count < count) { >> error_report("Error: Setting storage keys for page beyond the end " >> - "of memory: gfn=%" PRIx64 " count=%" PRId64 "\n", start_gfn, >> - count); >> + "of memory: gfn=%" PRIx64 " count=%" PRId64, >> + start_gfn, count); > > Do we want a separate patch cleaning up 'Error: ' prefixes? After my Christmas break, in a separate series probably.