Received: from eggs.gnu.org ([2001:4830:134:3::10]:56745) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZbSxf-0004dR-Rv for qemu-devel@nongnu.org; Mon, 14 Sep 2015 08:34:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZbSxa-0001kD-Su for qemu-devel@nongnu.org; Mon, 14 Sep 2015 08:34:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33776) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZbSxa-0001k0-N8 for qemu-devel@nongnu.org; Mon, 14 Sep 2015 08:34:14 -0400 From: Markus Armbruster References: Date: Mon, 14 Sep 2015 14:34:10 +0200 In-Reply-To: (=?utf-8?B?Iks=?= =?utf-8?B?xZF2w6Fnw7MsIFpvbHTDoW4iJ3M=?= message of "Mon, 7 Sep 2015 14:08:05 +0200") Message-ID: <87r3m1p4cd.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 0/7] qapi-flattening and preparation of -audiodev option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?utf-8?B?S8WRdsOhZ8OzLCBab2x0w6Fu?= Cc: qemu-devel@nongnu.org, Eduardo Habkost "K=C5=91v=C3=A1g=C3=B3, Zolt=C3=A1n" writes: > As discussed here[1], I'm splitting the qapi related patches from my > previous -audiodev patch series. These are patches 2--7 and 9 from my > previous patches. (Patch 1 was merged into -trivial in the meanwhile.) > > Please review. > > [1]: http://lists.nongnu.org/archive/html/qemu-devel/2015-09/msg01505.html Ongoing QAPI work has shown that the visitors code is brittle, and we need to retrofit a proper contract[*]. As discussed before, you're proposing dropping a design assumption of OptsVisitor. Messing with design assumptions is always scary, but it's even scarier when the whole edifice built on it has been found brittle already. I'm afraid we need retrofit a contract *first*, both to build understanding on how this sucker is supposed to work (right now nobody knows), and to hopefully make it more robust. Your series adds urgency to the job. [*] http://lists.nongnu.org/archive/html/qemu-devel/2015-09/msg03363.html