Received: from eggs.gnu.org ([2001:4830:134:3::10]:54345) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VjRIE-0003tD-6p for qemu-devel@nongnu.org; Thu, 21 Nov 2013 05:15:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VjRI8-0004uA-80 for qemu-devel@nongnu.org; Thu, 21 Nov 2013 05:15:26 -0500 Received: from mx1.redhat.com ([209.132.183.28]:29941) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VjRI7-0004u6-Vf for qemu-devel@nongnu.org; Thu, 21 Nov 2013 05:15:20 -0500 From: Markus Armbruster References: <1385001528-12003-1-git-send-email-imammedo@redhat.com> <1385001528-12003-6-git-send-email-imammedo@redhat.com> Date: Thu, 21 Nov 2013 11:15:06 +0100 In-Reply-To: <1385001528-12003-6-git-send-email-imammedo@redhat.com> (Igor Mammedov's message of "Thu, 21 Nov 2013 03:38:26 +0100") Message-ID: <87r4aaxdqt.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH 05/27] qapi: add SIZE type parser to string_input_visitor List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: peter.maydell@linaro.org, aliguori@amazon.com, stefanb@linux.vnet.ibm.com, hutao@cn.fujitsu.com, mst@redhat.com, mjt@tls.msk.ru, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, vasilis.liaskovitis@profitbricks.com, quintela@redhat.com, kraxel@redhat.com, stefanha@redhat.com, pbonzini@redhat.com, marcel.a@redhat.com, lcapitulino@redhat.com, chegu_vinod@hp.com, afaerber@suse.de Igor Mammedov writes: > Signed-off-by: Igor Mammedov > --- > qapi/string-input-visitor.c | 18 ++++++++++++++++++ > 1 files changed, 18 insertions(+), 0 deletions(-) > > diff --git a/qapi/string-input-visitor.c b/qapi/string-input-visitor.c > index 8f1bc41..a152f5d 100644 > --- a/qapi/string-input-visitor.c > +++ b/qapi/string-input-visitor.c > @@ -97,6 +97,23 @@ static void parse_type_number(Visitor *v, double *obj, const char *name, > *obj = val; > } > > +static void parse_type_size(Visitor *v, uint64_t *obj, const char *name, > + Error **errp) > +{ > + StringInputVisitor *siv = DO_UPCAST(StringInputVisitor, visitor, v); > + int64_t val; > + char *endp; > + > + val = strtosz_suffix(siv->string ? siv->string : "", &endp, > + STRTOSZ_DEFSUFFIX_B); > + if (val < 0 || *endp != '\0') { > + error_set(errp, QERR_INVALID_PARAMETER_VALUE, name, > + "a size value representible as a non-negative int64"); > + return; > + } > + *obj = val; > +} > + > static void parse_start_optional(Visitor *v, bool *present, > const char *name, Error **errp) > { > @@ -131,6 +148,7 @@ StringInputVisitor *string_input_visitor_new(const char *str) > v->visitor.type_bool = parse_type_bool; > v->visitor.type_str = parse_type_str; > v->visitor.type_number = parse_type_number; > + v->visitor.type_size = parse_type_size; > v->visitor.start_optional = parse_start_optional; > > v->string = str; Does this put syntax like "value": "128M" in QMP? If yes, NAK. QMP does not want fancy syntax for numbers, only plain numbers.