From: Eric Anholt Subject: Re: [PATCH] intel: Update for new i915_drm.h defines. Date: Wed, 04 Jan 2012 14:48:37 -0800 Message-ID: <87r4zfcce2.fsf@eliezer.anholt.net> References: <1325646600-6366-1-git-send-email-eric@anholt.net> <20120104085234.3ee51fc7@jbarnes-desktop> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1957149523==" Return-path: In-Reply-To: <20120104085234.3ee51fc7@jbarnes-desktop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jesse Barnes Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============1957149523== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" --=-=-= Content-Transfer-Encoding: quoted-printable On Wed, 4 Jan 2012 08:52:34 -0800, Jesse Barnes = wrote: > On Tue, 3 Jan 2012 19:10:00 -0800 > Eric Anholt wrote: >=20 > > --- > >=20 > > This syncs the code up to the kernel as of the gen7 SOL changes. It > > would be nice if doing this was just a straight copy of the kernel > > code -- there are two diffs left out. One is this hunk: > >=20 > > -#ifdef __KERNEL__ > > -/* For use by IPS driver */ > > -extern unsigned long i915_read_mch_val(void); > > -extern bool i915_gpu_raise(void); > > -extern bool i915_gpu_lower(void); > > -extern bool i915_gpu_busy(void); > > -extern bool i915_gpu_turbo_disable(void); > > -#endif > >=20 > > Does anyone see any real reason to be dropping this? > >=20 > > The other is removing the sparse __user annotations on the structs. > > Could we just patch the kernel to #define it away for userland, so we > > could make updating this file just a matter of "cp"? >=20 > Having just done this locally, I'm in favor. The stuff under > __KERNEL__ should be harmless; don't see why we can't just copy it. >=20 > For the __user define, we must be missing a compiler.h include > somewhere in the libdrm case. If you explicitly include it do the > errors go away? What version of POSIX is compiler.h part of? Remember that this is userland code built across OSes (as much as we try to forget that). --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEARECAAYFAk8E10UACgkQHUdvYGzw6veJsgCggM0GeufvrPz1wpUMn9/lc9EH QAAAn1vk6MgoGLTbWTat65Wnax/Hgcmh =XCau -----END PGP SIGNATURE----- --=-=-=-- --===============1957149523== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============1957149523==--