Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Msbst-0002lH-Do for qemu-devel@nongnu.org; Tue, 29 Sep 2009 08:32:47 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Msbso-0002iq-0K for qemu-devel@nongnu.org; Tue, 29 Sep 2009 08:32:46 -0400 Received: from [199.232.76.173] (port=48649 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Msbsn-0002iO-I3 for qemu-devel@nongnu.org; Tue, 29 Sep 2009 08:32:41 -0400 Received: from mx20.gnu.org ([199.232.41.8]:21805) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Msbsn-0000XN-87 for qemu-devel@nongnu.org; Tue, 29 Sep 2009 08:32:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Msbsm-00073l-EO for qemu-devel@nongnu.org; Tue, 29 Sep 2009 08:32:40 -0400 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n8TCWceY007617 for ; Tue, 29 Sep 2009 08:32:38 -0400 Subject: Re: [Qemu-devel] [PATCH 0/3] Clean up error handling in net.c References: <20090928164127.4f3c6641@doriath> From: Markus Armbruster Date: Tue, 29 Sep 2009 14:32:36 +0200 In-Reply-To: <20090928164127.4f3c6641@doriath> (Luiz Capitulino's message of "Mon\, 28 Sep 2009 16\:41\:27 -0300") Message-ID: <87r5tq53tn.fsf@pike.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: qemu-devel@nongnu.org Luiz Capitulino writes: > On Mon, 28 Sep 2009 21:11:32 +0200 > Markus Armbruster wrote: > >> Caveat: I'm not familiar with slirp, and I'm not sure 1/3 is the right >> thing to do. > > FWIW, I'm working on a infrastructure for error handling in the Monitor. > > The goal is not only to fix abort/don't abort cases, but also to pass > error information up in the call stack, so that the protocol can emit it. > > So, in case you are planning to fix more of those abort cases, I would > really appreciate if you do this as part of a QObject conversion, > otherwise I would have to re-visit the handler to do the conversion > myself. Understood. This time around, I didn't get close to the handler. I just fixed low-level code called from both startup and monitor. > I should post patches this week, although I'm not sure if I've picked > up the best API design for this... Yes, show us the code :)