Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JMHPE-00015k-0J for mharc-grub-devel@gnu.org; Tue, 05 Feb 2008 01:35:44 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JMHPC-00012x-Ar for grub-devel@gnu.org; Tue, 05 Feb 2008 01:35:42 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JMHPA-00010Q-O4 for grub-devel@gnu.org; Tue, 05 Feb 2008 01:35:41 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JMHPA-00010H-E4 for grub-devel@gnu.org; Tue, 05 Feb 2008 01:35:40 -0500 Received: from smtp-vbr5.xs4all.nl ([194.109.24.25]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JMHPA-0000eC-0p for grub-devel@gnu.org; Tue, 05 Feb 2008 01:35:40 -0500 Received: from localhost.localdomain (249-174.surfsnel.dsl.internl.net [145.99.174.249]) by smtp-vbr5.xs4all.nl (8.13.8/8.13.8) with ESMTP id m156ZcB7074182 for ; Tue, 5 Feb 2008 07:35:39 +0100 (CET) (envelope-from mgerards@xs4all.nl) From: Marco Gerards To: The development of GRUB 2 References: <1202074413.560.7.camel@k9.localnet> <874pco90mm.fsf@xs4all.nl> <1202156471.582.11.camel@k9.localnet> <20080204222712.GA28299@thorin> Mail-Copies-To: mgerards@xs4all.nl Date: Tue, 05 Feb 2008 07:37:29 +0100 In-Reply-To: (wa1ter@myrealbox.com's message of "Mon, 04 Feb 2008 14:55:34 -0800") Message-ID: <87r6fr6h92.fsf@xs4all.nl> User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by XS4ALL Virus Scanner X-detected-kernel: by monty-python.gnu.org: FreeBSD 4.6-4.9 Subject: Re: [PATCH] to make grub2 compile on NetBSD X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Feb 2008 06:35:42 -0000 walt writes: > Robert Millan wrote: >>>> walt writes: >>>> >>>>> NetBSD's gcc wants libgcc and libc to define __enable_execute_stack, >>>>> but this is useless for a free-standing executable like grub. Define >>>>> a dummy function in lieu of libgcc to supply __enable_execute_stack. > >>> Second try: >>> >>> Make NetBSD's gcc happy. >>> >>> * kern/mm.c: New dummy symbol __enable_execute_stack. >>> (include/grub/mm.h): Likewise. >> >> This ChangeLog entry seems wrong. I'll write it up for you, as it's easier to >> explain with an example: >> >> Make NetBSD's gcc happy. >> >> * include/grub/mm.h >> [__NetBSD__] (__enable_execute_stack): New function prototype. >> * kern/mm.c >> [__NetBSD__] (__enable_execute_stack): New function. > > Okay, thanks. Does the [__NetBSD__] token denote an #ifdef? How > would I indicate a patch for, say, Net/Free/Dragonfly BSD's at the > same time? > > Oh, and should you mention that the new function does nothing? > > Marco: I didn't add the header for the changelog because I don't > know who (if anyone) is going to commit it. Your name and email address should be used when committing, at least that's preferred. The date will be updated to the commit date when committing. -- Marco