Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A6CE194 for ; Mon, 5 Jun 2023 07:35:57 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 54B1221AF9; Mon, 5 Jun 2023 07:35:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1685950550; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WM1VYeRiPI0gK99qp7cgaYfMmsErgvMnsEQDPIt+seI=; b=oknVIiiwTETtKr7f/yaPAdZt+Jj+icPNX0KAlzqjajWRj4GvccRNjFFWH34P4BcIRvwll8 p4NJshNjcdJfrDd4GeYPAmcxPXpfyUTiyPcoiPunUcMphn0g0AfvFj5m+xzuvciG9EobNZ z1AL/zAtnWMneYwrgRqtJxgx67nl1aY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1685950550; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WM1VYeRiPI0gK99qp7cgaYfMmsErgvMnsEQDPIt+seI=; b=D340LMFovvwGSx42EOj2ZswqC4Pr+bGevLyIwkgH32/QSUl09QE+B5j+HBKZ1Av1NdHSFs EhschHQPi7qlzlAA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1EC34139C7; Mon, 5 Jun 2023 07:35:50 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id r7yTBlaQfWSxbwAAMHmgww (envelope-from ); Mon, 05 Jun 2023 07:35:50 +0000 Date: Mon, 05 Jun 2023 09:35:49 +0200 Message-ID: <87sfb6icoa.wl-tiwai@suse.de> From: Takashi Iwai To: Yanteng Si Cc: tiwai@suse.com, perex@perex.cz, chenhuacai@loongson.cn, alsa-devel@alsa-project.org, loongarch@lists.linux.dev, loongson-kernel@lists.loongnix.cn, Yingkun Meng Subject: Re: [PATCH 2/4] ALSA: hda: Using polling mode for loongson controller by default In-Reply-To: References: User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 Precedence: bulk X-Mailing-List: loongarch@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII On Wed, 31 May 2023 05:21:32 +0200, Yanteng Si wrote: > > On loongson controller, RIRBSTS.RINTFL cannot be cleared, > azx_interrupt() is called all the time. We disable RIRB > interrupt, and use polling mode by default. > > Signed-off-by: Yanteng Si > Signed-off-by: Yingkun Meng > --- > sound/hda/hdac_controller.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/sound/hda/hdac_controller.c b/sound/hda/hdac_controller.c > index 3c7af6558249..dbaa19cb8162 100644 > --- a/sound/hda/hdac_controller.c > +++ b/sound/hda/hdac_controller.c > @@ -10,6 +10,7 @@ > #include > #include > #include "local.h" > +#include "../pci/hda/hda_controller.h" > > /* clear CORB read pointer properly */ > static void azx_clear_corbrp(struct hdac_bus *bus) > @@ -42,6 +43,8 @@ static void azx_clear_corbrp(struct hdac_bus *bus) > */ > void snd_hdac_bus_init_cmd_io(struct hdac_bus *bus) > { > + struct azx *chip = bus_to_azx(bus); You can't convert in this way in the generic HD-audio bus code in sound/hda/*. The struct azx is specific to sound/pci/hda/*. > WARN_ON_ONCE(!bus->rb.area); > > spin_lock_irq(&bus->reg_lock); > @@ -79,7 +82,10 @@ void snd_hdac_bus_init_cmd_io(struct hdac_bus *bus) > /* set N=1, get RIRB response interrupt for new entry */ > snd_hdac_chip_writew(bus, RINTCNT, 1); > /* enable rirb dma and response irq */ > - snd_hdac_chip_writeb(bus, RIRBCTL, AZX_RBCTL_DMA_EN | AZX_RBCTL_IRQ_EN); > + if (chip->driver_caps & AZX_DCAPS_LOONGSON_WORKAROUND) > + snd_hdac_chip_writeb(bus, RIRBCTL, AZX_RBCTL_DMA_EN); > + else > + snd_hdac_chip_writeb(bus, RIRBCTL, AZX_RBCTL_DMA_EN | AZX_RBCTL_IRQ_EN); That is, for some device-specific workaround like this, you'd need to introduce a new flag in struct hdac_bus, set up in the sound/pci/hda/hda_intel.c instead. thanks, Takashi