Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69DF0C56202 for ; Wed, 25 Nov 2020 10:28:11 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8DEDE206E0 for ; Wed, 25 Nov 2020 10:28:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="fYsNF3eC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8DEDE206E0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:45102 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1khs1x-000298-EX for qemu-devel@archiver.kernel.org; Wed, 25 Nov 2020 05:28:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:46266) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1khs1H-0001Jj-BK for qemu-devel@nongnu.org; Wed, 25 Nov 2020 05:27:27 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:30747) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1khs1F-0002A2-0v for qemu-devel@nongnu.org; Wed, 25 Nov 2020 05:27:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606300042; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HMrxogfCrQ29Nar4bkLcQsNoXzRXjhVlOgkS+Ad05EE=; b=fYsNF3eC5Wu7YNm3sd674aZtDir1fJsNe7F2Kq0YT42Lz5UoUGve3oeq6TIoT/ygLYJAwQ fk8eXAvXUZVkYwm0WvMid3QRfwyh20dFfAAY4rty9NQeJukKv1JhfYsqS0YivW3ETm1OkH nsNA1hvEIX1mYT+yJsPJuz0YO1IwIcM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-410-INjUzM7VMyqUIHLWQLEHYg-1; Wed, 25 Nov 2020 05:27:19 -0500 X-MC-Unique: INjUzM7VMyqUIHLWQLEHYg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D2AC71084431; Wed, 25 Nov 2020 10:27:17 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-112-103.ams2.redhat.com [10.36.112.103]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 88CFD2BFE4; Wed, 25 Nov 2020 10:27:17 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 19161113864E; Wed, 25 Nov 2020 11:27:16 +0100 (CET) From: Markus Armbruster To: Yuri Benditovich Subject: Re: [PATCH] hmp: Changed hmp_netdev_add() using qmp_marshal_netdev_add() References: <20200716035532.1407660-1-andrew@daynix.com> <874klk5gnc.fsf@dusky.pond.sub.org> <87lfesv2zu.fsf@dusky.pond.sub.org> <87blfnp20k.fsf@dusky.pond.sub.org> <87lferm4x5.fsf@dusky.pond.sub.org> <87tutej3dc.fsf@dusky.pond.sub.org> <87blfmj2qx.fsf@dusky.pond.sub.org> <87y2iqg3m3.fsf@dusky.pond.sub.org> Date: Wed, 25 Nov 2020 11:27:16 +0100 In-Reply-To: (Yuri Benditovich's message of "Wed, 25 Nov 2020 10:54:44 +0200") Message-ID: <87sg8xafzv.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Received-SPF: pass client-ip=63.128.21.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Yan Vugenfirer , Andrew Melnichenko , qemu-devel@nongnu.org, "Dr. David Alan Gilbert" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Yuri Benditovich writes: > On Tue, Nov 24, 2020 at 5:46 PM Markus Armbruster wrote: [...] >> The CLI accumulates -netdev in option group "netdev". It has to, or >> else -writeconfig doesn't work. >> >> Before commit 08712fcb85 "net: Track netdevs in NetClientState rather >> than QemuOpt", netdev_add added to the option group, and netdev_del >> removed from it, both for HMP and QMP. Thus, every netdev had a >> corresponding QemuOpts in this option group. >> >> Commit 08712fcb85 dropped this for QMP netdev_add and both netdev_del. >> Now a netdev has a corresponding QemuOpts only when it was created with >> CLI or HMP. Two issues: >> >> * QMP netdev_add loses its "no duplicate ID" check. >> >> My change to net_init_client1() fixes this. >> >> * Both netdev_add can leave QemuOpts behind, breaking HMP netdev_add. >> >> My change to qmp_netdev_del() fixes this. >> >> Questions? >> > No questions, looking forward for the final patch > Thanks Posted: Subject: [PATCH 0/1] net: Fix handling of id in netdev_add and netdev_del Message-Id: <20201125100220.50251-1-armbru@redhat.com> Thanks for your help, guys, I appreciate it!