Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A602CC43467 for ; Tue, 20 Oct 2020 06:45:45 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1E333223C6 for ; Tue, 20 Oct 2020 06:45:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="XCyFCNlW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1E333223C6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:59620 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kUlOy-0005KJ-4F for qemu-devel@archiver.kernel.org; Tue, 20 Oct 2020 02:45:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51528) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kUlNh-0003jB-HL for qemu-devel@nongnu.org; Tue, 20 Oct 2020 02:44:27 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:54470) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kUlNd-0003iP-JH for qemu-devel@nongnu.org; Tue, 20 Oct 2020 02:44:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603176260; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dnm3MuVuqPsH96v1+CrYOsrveUTTsqzl+gjKUAL5mG8=; b=XCyFCNlWLCLCxcHtCuidm2KD5jJMyJDOg4tLoLpJK2eSCVOcQjOkt9V42bJCM7GCoBpA81 aQkSjsM2TJbVjWd3Yohre8nEwKiYT4arBtRQJ0+8xtQzXuFWcQqWwXei0AArcnomKlMsdJ HPTl0JHWEk6Q2hs4a5cEW/6MqoH9Kow= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-153-zT6Bkl2dPhWnuHWJmA6x7g-1; Tue, 20 Oct 2020 02:44:18 -0400 X-MC-Unique: zT6Bkl2dPhWnuHWJmA6x7g-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A099357083 for ; Tue, 20 Oct 2020 06:44:17 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-112-182.ams2.redhat.com [10.36.112.182]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 72A3F60BF3; Tue, 20 Oct 2020 06:44:17 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 19D5F1132A08; Tue, 20 Oct 2020 08:44:16 +0200 (CEST) From: Markus Armbruster To: John Snow Subject: Re: [PATCH] scripts/qmp: delete 'qmp' script References: <20201019210430.1063390-1-jsnow@redhat.com> Date: Tue, 20 Oct 2020 08:44:16 +0200 In-Reply-To: <20201019210430.1063390-1-jsnow@redhat.com> (John Snow's message of "Mon, 19 Oct 2020 17:04:30 -0400") Message-ID: <87sga9z9a7.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Received-SPF: pass client-ip=216.205.24.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/20 01:16:16 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, Eduardo Habkost Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" John Snow writes: > This script has not seen a patch that was specifically for this script > since it was moved to this location in 2013, and I doubt it is used. It > uses "man qmp" for its help message, which does not exist. It also > presumes there is a manual page for qmp-XXX, for each defined qmp > command XXX. I don't think that's true. > > The format it expects arguments in is something like: > > block-dirty-bitmap-add --node=foo --name=bar > > and has no capacity to support nested JSON arguments, either. > > Most developers use either qmp-shell or socat (or pasting JSON directly > into qmp stdio), so this duplication and additional alternate syntax is > not helpful. > > Remove it. Leave a breadcrumb script just in case, to be removed next > release cycle. > > Signed-off-by: John Snow Queued, thanks!