Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD7E7C4741F for ; Mon, 28 Sep 2020 07:48:20 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 58E7421531 for ; Mon, 28 Sep 2020 07:48:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="VYNUO11F" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 58E7421531 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:55124 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kMntS-0004jC-RB for qemu-devel@archiver.kernel.org; Mon, 28 Sep 2020 03:48:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56052) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kMnsP-00049z-6d for qemu-devel@nongnu.org; Mon, 28 Sep 2020 03:47:13 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:25186) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kMnsM-0000AH-Uw for qemu-devel@nongnu.org; Mon, 28 Sep 2020 03:47:12 -0400 Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601279228; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2S1PH8fgl/m/XiRfTLwXigu/0R6Ccfkc5QMUsc7r8UY=; b=VYNUO11F7c7A1+OurxJmXRk893+fkqMC5BRR2JPRJYfKDEeiaryyVIqb3xe5BqmT+WlIGE MMRncVwMSQGjT0Pse02Zst0aWAXKHfDxOXvDI34AAyX+aXAbEDsSKEjmJzJ4hn5WElOjC+ DihT5HFN8zZVV6heZuhAOatcmyDC/R0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-116-dwqyfoFGOe2_jIQPAc2kFQ-1; Mon, 28 Sep 2020 03:47:06 -0400 X-MC-Unique: dwqyfoFGOe2_jIQPAc2kFQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A332F1868405; Mon, 28 Sep 2020 07:47:05 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-112-70.ams2.redhat.com [10.36.112.70]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 29D4F27BCE; Mon, 28 Sep 2020 07:47:02 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id B4EE1113865F; Mon, 28 Sep 2020 09:47:00 +0200 (CEST) From: Markus Armbruster To: Kevin Wolf Subject: Re: [PATCH v7 07/13] monitor: Make current monitor a per-coroutine property References: <20200909151149.490589-1-kwolf@redhat.com> <20200909151149.490589-8-kwolf@redhat.com> <874ko0o0jv.fsf@dusky.pond.sub.org> <20200925152307.GF5731@linux.fritz.box> Date: Mon, 28 Sep 2020 09:47:00 +0200 In-Reply-To: <20200925152307.GF5731@linux.fritz.box> (Kevin Wolf's message of "Fri, 25 Sep 2020 17:23:07 +0200") Message-ID: <87sgb2l4wb.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Received-SPF: pass client-ip=63.128.21.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/28 03:47:08 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -36 X-Spam_score: -3.7 X-Spam_bar: --- X-Spam_report: (-3.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.576, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=-1, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-block@nongnu.org, marcandre.lureau@gmail.com, qemu-devel@nongnu.org, stefanha@redhat.com, dgilbert@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Kevin Wolf writes: > Am 14.09.2020 um 17:11 hat Markus Armbruster geschrieben: >> Kevin Wolf writes: >> >> > This way, a monitor command handler will still be able to access the >> > current monitor, but when it yields, all other code code will correctly >> > get NULL from monitor_cur(). >> > >> > This uses a hash table to map the coroutine pointer to the current >> > monitor of that coroutine. Outside of coroutine context, we associate >> > the current monitor with the leader coroutine of the current thread. >> >> In qemu-system-FOO, the hash table can have only these entries: >> >> * (OOB) One mapping @mon_iothread's thread leader to a QMP monitor, while >> executing a QMP command out-of-band. >> >> * (QMP-CO) One mapping @qmp_dispatcher_co (a coroutine in the main >> thread) to a QMP monitor, while executing a QMP command in-band and in >> coroutine context. >> >> * (QMP) One mapping the main thread's leader to a QMP monitor, while >> executing a QMP command in-band and out of coroutine context, in a >> bottom half. >> >> * (HMP) One mapping the main thread's leader to an HMP monitor, while >> executing an HMP command out of coroutine context. >> >> * (HMP-CO) One mapping a transient coroutine in the main thread to an >> HMP monitor, while executing an HMP command in coroutine context. >> >> In-band execution is one command after the other. >> >> Therefore, at most one monitor command can be executing in-band at any >> time. >> >> Therefore, the hash table has at most *two* entries: one (OOB), and one >> of the other four. >> >> Can you shoot any holes into my argument? > > I think with human-monitor-command, you can have three mappings: > > 1. The main thread's leader (it is a non-coroutine QMP command) to the > QMP monitor This is (QMP). > 2. With a coroutine HMP command, one mapping from the transient HMP > coroutine to the transient HMP monitor (with a non-coroutine HMP > command, we'd instead temporarily change the mapping from 1.) This is (HMP-CO). > 3. The OOB entry This is (OOB). To get 1. (QMP) and 2, (HMP-CO) at the same time, the in-band, non-coroutine QMP command needs to execute interleaved with the in-band, coroutine HMP command. Such an interleaving contradicts "In-band execution is one command after the other", which is a fundamental assumption in-band commands may make. If the assumption is invalid, we got a problem. Is it? >> I suspect there's a simpler solution struggling to get out. But this >> solution works, so in it goes. Should the simpler one succeed at >> getting out, it can go in on top. If not, I'll probably add even more >> comments to remind myself of these facts. > > I think the simple approach you had posted could work if you can fill in > the HMP part, but I think it wasn't completely trivial and you told me > not to bother for now, Correct. I decided to go with the code you already tested. > so I didn't. It may still be a viable path > forward if you like it better.