Received: by 2002:ac2:4c26:0:0:0:0:0 with SMTP id u6csp559711lfq; Wed, 23 Sep 2020 08:23:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz8MKkjcpBPeyiF1l/IGqDavdRmCjeRAzDdVXwRaJDk8oLjwxTPZX+CMplRJTkGz8I4FIAe X-Received: by 2002:a25:3384:: with SMTP id z126mr777065ybz.422.1600874627497; Wed, 23 Sep 2020 08:23:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600874627; cv=none; d=google.com; s=arc-20160816; b=wuLLLg4jcokjDwKuMlEAlWR+S8mPU6tQEcCXMA5rTLSWeahRGPiAbA/9oWuL7iNNCG XuPakWSsYugF1NucCwssTjorVXC7IsWLAqJzlB3iNGaPf6lmHYTsJa+IoBZOmRZdVtf/ 1QO07b9A7YzXJaSX5w650VTw91qyX3C+Q7I/0sHGP4ysCx47f0kIz2bp9j4Inscv9Sbx QeoUh91qSgw96C+XEocn+rsM4a6dB6JWQ3kNiDIBeRQAy8dcFxwFuZDqEwZw+cWoWi9G DV6eySOPu82Lp4p7AeuA8MEqhjayCeWakcEgGk+G01vu+XhKB78Va2jUfPV2Z7qu3nec vmkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:user-agent:message-id:in-reply-to:date:references :subject:to:from:dkim-signature; bh=HqIL6f9jCxFn9/51dPcCr4LHPHEretPTZzT8MDT+X9k=; b=GVFExFPT3H0i4lYXtsmxwrteXcYQMjZuR6pgysMRHoEyCeRNON6rN9b1r3N2WNIzP+ vU1mmX0E0bOLDaK3uA633ajlyUS7d8gcrzzpBf/1mKjqG1M+w+sBl1kYRh+lSxSxLJ60 QBLhZHBmlyPORP4y9fQ5JWctpvVZZehrQKpddZgo7EDaO9PZJ/VXnQU5wOBbmPrFKDR5 g1Gy8uwIClR7FUfxwXeRrocAFZ9XtlmlXxgAP1tIwyRsNPMUiEQUZBlRGKvMStCczzPd 6U81oLMhkY9LB/7NLOp9k3E0g4EkonlV7wQkEZAljiTlF9UOwsTJ6IjwKLteXUXtliEe 4NCw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b=CcADCPXA; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d18si282759ybn.244.2020.09.23.08.23.47 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 23 Sep 2020 08:23:47 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b=CcADCPXA; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:54182 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kL6cU-0000WD-RD for alex.bennee@linaro.org; Wed, 23 Sep 2020 11:23:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35200) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kL6XG-0002PH-Dj for qemu-arm@nongnu.org; Wed, 23 Sep 2020 11:18:24 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:33267) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kL6XA-0004pZ-KY for qemu-arm@nongnu.org; Wed, 23 Sep 2020 11:18:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600874295; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HqIL6f9jCxFn9/51dPcCr4LHPHEretPTZzT8MDT+X9k=; b=CcADCPXABZDQQZCDQnoR/88kfruwFwCj4tKVO8nEwXJuy7sVAB+cDSSjw22mxYVVqYrx/9 LYv3IGGjqe2QNvL9RUCwPmX1w1Jr/XNvvNcZ+mj+kr8Cit7ZJswL9zSy2HufqicVT56EFK RXPGPoVdGQQrBZzuTXtW8CPYzO/Dnf0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-394-OQJC_lmOOCS5FkgSarRK7A-1; Wed, 23 Sep 2020 11:17:49 -0400 X-MC-Unique: OQJC_lmOOCS5FkgSarRK7A-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8DA2DAE821; Wed, 23 Sep 2020 15:17:48 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-114-66.ams2.redhat.com [10.36.114.66]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3A3287368A; Wed, 23 Sep 2020 15:17:45 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id C6F441132E9A; Wed, 23 Sep 2020 17:17:43 +0200 (CEST) From: Markus Armbruster To: Daniel P. =?utf-8?Q?Berrang=C3=A9?= Subject: Re: [PATCH v3 3/3] qemu-options: document SMBIOS type 11 settings References: <20200923133804.2089190-1-berrange@redhat.com> <20200923133804.2089190-4-berrange@redhat.com> Date: Wed, 23 Sep 2020 17:17:43 +0200 In-Reply-To: <20200923133804.2089190-4-berrange@redhat.com> ("Daniel P. =?utf-8?Q?Berrang=C3=A9=22's?= message of "Wed, 23 Sep 2020 14:38:04 +0100") Message-ID: <87sgb834ko.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=63.128.21.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/23 00:53:58 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.228, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NUMERIC_HTTP_ADDR=1.242, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, WEIRD_PORT=0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Eduardo Habkost , "Michael S. Tsirkin" , Laszlo Ersek , qemu-devel@nongnu.org, qemu-arm@nongnu.org, Paolo Bonzini , Igor Mammedov , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Richard Henderson Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-arm" X-TUID: hFAffLKsD6xU Daniel P. Berrang=C3=A9 writes: > Reviewed-by: Philippe Mathieu-Daud=C3=A9 > Signed-off-by: Daniel P. Berrang=C3=A9 > --- > qemu-options.hx | 41 +++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 41 insertions(+) > > diff --git a/qemu-options.hx b/qemu-options.hx > index 47f64be0c0..2cb034bce3 100644 > --- a/qemu-options.hx > +++ b/qemu-options.hx > @@ -2296,6 +2296,8 @@ DEF("smbios", HAS_ARG, QEMU_OPTION_smbios, > "-smbios type=3D4[,sock_pfx=3Dstr][,manufacturer=3Dstr][,version=3Ds= tr][,serial=3Dstr]\n" > " [,asset=3Dstr][,part=3Dstr][,max-speed=3D%d][,current= -speed=3D%d]\n" > " specify SMBIOS type 4 fields\n" > + "-smbios type=3D11[,value=3Dstr][,path=3Dfilename]\n" > + " specify SMBIOS type 11 fields\n" > "-smbios type=3D17[,loc_pfx=3Dstr][,bank=3Dstr][,manufacturer=3Dstr]= [,serial=3Dstr]\n" > " [,asset=3Dstr][,part=3Dstr][,speed=3D%d]\n" > " specify SMBIOS type 17 fields\n", > @@ -2319,6 +2321,45 @@ SRST > ``-smbios type=3D4[,sock_pfx=3Dstr][,manufacturer=3Dstr][,version=3Dstr]= [,serial=3Dstr][,asset=3Dstr][,part=3Dstr]`` > Specify SMBIOS type 4 fields > =20 > +``-smbios type=3D11[,value=3Dstr][,path=3Dfilename]`` > + Specify SMBIOS type 11 fields inline "inline"? > + > + This argument can be repeated multiple times, and values are added i= n the order they are parsed. > + Applications intending to use OEM strings data are encouraged to use= their application name as > + a prefix for the value string. This facilitates passing information = for multiple applications > + concurrently. > + > + The ``value=3Dstr`` syntax provides the string data inline, while th= e ``path=3Dfilename`` syntax > + loads data from a file on disk. Note that the file is not permitted = to contain any NUL bytes. Out of curiosity: what happens when it does? > + > + Both the ``value`` and ``path`` options can be repeated multiple tim= es and will be added to > + the SMBIOS table in the order in which they appear. > + > + Note that on the x86 architecture, the total size of all SMBIOS tabl= es is limited to 65535 > + bytes. Thus the OEM strings data is not suitable for passing large a= mounts of data into the > + guest. Instead it should be used as a indicator to inform the guest = where to locate the real > + data set, for example, by specifying the serial ID of a block device= . > + > + An example passing three strings is > + > + .. parsed-literal:: > + > + -smbios type=3D11,value=3Dcloud-init:ds=3Dnocloud-net;s=3Dhttp:/= /10.10.0.1:8000/,\\ > + value=3Danaconda:method=3Dhttp://dl.fedoraprojec= t.org/pub/fedora/linux/releases/25/x86_64/os,\\ > + path=3D/some/file/with/oemstringsdata.txt > + > + In the guest OS this is visible with the ``dmidecode`` command > + > + .. parsed-literal:: > + > + $ dmidecode -t 11 > + Handle 0x0E00, DMI type 11, 5 bytes > + OEM Strings > + String 1: cloud-init:ds=3Dnocloud-net;s=3Dhttp://10.10.0.1= :8000/ > + String 2: anaconda:method=3Dhttp://dl.fedoraproject.org/pu= b/fedora/linux/releases/25/x86_64/os > + String 3: myapp:some extra data > + > + > ``-smbios type=3D17[,loc_pfx=3Dstr][,bank=3Dstr][,manufacturer=3Dstr][,s= erial=3Dstr][,asset=3Dstr][,part=3Dstr][,speed=3D%d]`` > Specify SMBIOS type 17 fields > ERST