From: Esben Haabendal Subject: Re: [PATCH] serial: 8250: Add support for using platform_device resources Date: Tue, 07 May 2019 13:35:58 +0200 Message-ID: <87sgtqjy3l.fsf@haabendal.dk> References: <20190430140416.4707-1-esben@geanix.com> <20190430153736.GL9224@smile.fi.intel.com> <874l6efxta.fsf@haabendal.dk> <20190502104556.GS9224@smile.fi.intel.com> <87pnp11112.fsf@haabendal.dk> <20190507093239.GB4529@dell> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <20190507093239.GB4529@dell> (Lee Jones's message of "Tue, 7 May 2019 10:32:39 +0100") Sender: linux-kernel-owner@vger.kernel.org To: Lee Jones , Andy Shevchenko Cc: linux-serial@vger.kernel.org, Enrico Weigelt , Greg Kroah-Hartman , Jiri Slaby , Darwin Dingel , Jisheng Zhang , Sebastian Andrzej Siewior , He Zhe , Marek Vasut , Douglas Anderson , Paul Burton , linux-kernel@vger.kernel.org List-Id: linux-serial@vger.kernel.org Lee Jones writes: > On Thu, 02 May 2019, Esben Haabendal wrote: > >> Could you help clarify whether or not this patch is trying to do >> something odd/wrong? >> >> I might be misunderstanding Andy (probably is), but the discussion >> revolves around the changes I propose where I change the serial8250 >> driver to use platform_get_resource() in favour of >> request_mem_region()/release_mem_region(). > > Since 'serial8250' is registered as a platform device, I don't see any > reason why it shouldn't have the capability to obtain its memory > regions from the platform_get_*() helpers. Good to hear. That is exactly what I am trying do with this patch. @Andy: If you still don't like my approach, could you please advice an acceptable method for improving the serial8250 driver to allow the use of platform_get_*() helpers? /Esben