Received: from eggs.gnu.org ([209.51.188.92]:53439) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hGdO0-0004Dv-Iq for qemu-devel@nongnu.org; Wed, 17 Apr 2019 01:45:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hGdNz-000423-NJ for qemu-devel@nongnu.org; Wed, 17 Apr 2019 01:45:32 -0400 From: Markus Armbruster References: <20190417025944.16154-1-ehabkost@redhat.com> Date: Wed, 17 Apr 2019 07:45:24 +0200 In-Reply-To: <20190417025944.16154-1-ehabkost@redhat.com> (Eduardo Habkost's message of "Tue, 16 Apr 2019 23:59:39 -0300") Message-ID: <87sguhyykr.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH 0/5] Remove qdev_get_machine() call from ppc_cpu_parse_featurestr() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: qemu-devel@nongnu.org, Peter Maydell , Thomas Huth , Like Xu , Riku Voipio , Mark Cave-Ayland , Laurent Vivier , qemu-ppc@nongnu.org, Igor Mammedov , Paolo Bonzini , David Gibson , Artyom Tarasenko , Richard Henderson Eduardo Habkost writes: > My initial goal was simple: removing the qdev_get_machine() call > from ppc_cpu_parse_featurestr() because I want to make > qdev_get_machine() available only to softmmu code. > > Before doing this, I had to make *-user not call > CPUClass::parse_features() anymore (it was pointless to call it, > anyway). > > While doing this, I decided to rename parse_cpu_model() to > something clearer (parse_cpu_option()). > > As a nice side effect, now the dependency between machine object > creation and parse_cpu_option() is not hidden anymore. Series Reviewed-by: Markus Armbruster