From: Jeremie Courreges-Anglas References: <1520185442-22901-1-git-send-email-selva.nair@...277...> <87efkz7k42.fsf@...2274...> Date: Mon, 05 Mar 2018 00:13:48 +0100 Message-ID: <87sh9fzb6b.fsf@...2274...> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Subject: Re: [Openvpn-devel] [PATCH] Do not assume that SSL_CTX_get/set_min/max_proto_version are macros List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Selva Nair Cc: openvpn-devel --=-=-= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Sun, Mar 04 2018, Selva Nair wrote: > Hi, > > On Sun, Mar 4, 2018 at 1:48 PM, Jeremie Courreges-Anglas = wrote: >> On Sun, Mar 04 2018, selva.nair@...277... wrote: >>> From: Selva Nair >>> >>> Openssl docs do not explicitly state these to be macros although they >>> are currently defined as such. >> >> Actually they are documented as macros by OpenSSL since day 1, see >> NOTES. > > You are right, I missed that in the docs. In that case my patch is not > needed especially so if libressl will provide those macros. It all depends if you want to support LibreSSL 2.6.x installations, as I'm not sure I'll be able to backport this in the 2.6 branch (which is supposed to receive security/reliability fixes only). > I'm still concerned about set and get functions coming from different > sources Indeed. A diff is floating to also add the getters to LibreSSL, hopefully this will make it in the upcoming 2.7.x release. > and may be we should fix that by requiring that if set is > defined we need get too. But that will once again break libressl > compatibility. --=-=-=--