From: Eric Anholt Subject: Re: [PATCH igt 4/9] igt/vc4_wait_bo: Add a test for VC4's wait-for-BO ioctl. Date: Thu, 04 Feb 2016 13:43:00 -0800 Message-ID: <87si18884b.fsf@eliezer.anholt.net> References: <1454535703-660-1-git-send-email-eric@anholt.net> <1454535703-660-4-git-send-email-eric@anholt.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1185004507==" Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Stone Cc: intel-gfx List-Id: intel-gfx@lists.freedesktop.org --===============1185004507== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain Daniel Stone writes: > Hi, > > On 3 February 2016 at 21:41, Eric Anholt wrote: >> + ret = ioctl(fd, DRM_IOCTL_VC4_WAIT_BO, &arg); >> + igt_assert(ret == -1 && errno == EINVAL); > > A couple of nitpicks: all these should be either do_ioctl() for > success, or do_ioctl_err() for failure, which not only cuts down the > number of lines a bit, but also shows you the exact condition which > occurred (e.g. it'll show that errno was -EBUSY rather than expected > -EINVAL without having to round-trip through the reporter). Similarly, > all your igt_assert(x == y) should be igt_assert_eq(x, y), or any of > the igt_assert_{eq,neq} variants, e.g. _u32 for comparing uint32_t. > You can also use do_or_die(foo) as shorthand for igt_assert_eq(foo, > 0). > > With those addressed: > Reviewed-by: Daniel Stone I converted everything but one of the ones in wait_bo, and pushed the updated series to the vc4 branch of my tree. I'll give it another couple of days in case anyone else has review to do on the series. Thanks! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJWs8XkAAoJELXWKTbR/J7oS+4P/jMbKG2ErgZJvtL/j4XAihXR S8EWzyIZziuR1V+yzaYtml1DHPPhVDE4GW8rM9C2GPf+RJtEk8labcYh2hxbecG8 lrEd8/uQU8rtwUbvZ4GPOIsxfcMlWTEp6vc4OjC3KonwpvXQkhWFc12eozK3fxvk T3zZ4Zw6ELjYU9OtppJZgLtKbYbJ2SYEmYJYuL6V72lpEbk8Pr3rdcJyjITIai1F K7pu3tKsR0lF5t9RGbZAcicXsjxVuz2/hWxGUAQLbUq1vrWx7sLxyi6KFe1IPk+Q QlZDL6r2puDPpAb6ynqRNPpxlDHucu+tEpKijQB9lqimnuoctEj2p+EMfXL9/ZPz wQhtgHR+3Wsc7XSh6Q8OD/WCCiaxML+iDs0IvVKRs9nDLG8+bv3ddRmyCaO5MGZG 8tj0N/TUNzTTijz7Zvoq2Lrb6spdHil0cWLyn8iqeJA4WpUh8iruDzG+mxPuYsdt SykMPuM/EwnsZ8ZUoEj3snTUCnWt6syHAKGQs4ziZr06YqzFkft5tihXx4MiB4DW kSsVFIfNUwqqJxzOuiAuj7wal93GXW9TET3yYHiW6nrpu1umqYfSAwACNMDix+s/ SSMH309Iczh7KJlWYDvHBdP+Bkr3gxPkiib3qVtrQdvTopGZrLJ1UndQ3LKndKJA yNmB3AcS/wby8RTKQaSH =N09N -----END PGP SIGNATURE----- --=-=-=-- --===============1185004507== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK --===============1185004507==--