Received: from eggs.gnu.org ([2001:4830:134:3::10]:59422) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZL6x8-00016z-1g for qemu-devel@nongnu.org; Fri, 31 Jul 2015 05:50:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZL6x3-0001ey-Ib for qemu-devel@nongnu.org; Fri, 31 Jul 2015 05:50:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41391) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZL6x3-0001dU-El for qemu-devel@nongnu.org; Fri, 31 Jul 2015 05:50:05 -0400 From: Markus Armbruster References: <1435782155-31412-13-git-send-email-armbru@redhat.com> <1438295587-19069-1-git-send-email-eblake@redhat.com> Date: Fri, 31 Jul 2015 11:50:02 +0200 In-Reply-To: <1438295587-19069-1-git-send-email-eblake@redhat.com> (Eric Blake's message of "Thu, 30 Jul 2015 16:33:07 -0600") Message-ID: <87si84u051.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [RFC PATCH 12.5/47] qapi: Document that input visitor semantics are prone to leaks List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org, Michael Roth Eric Blake writes: > Most functions that can return a pointer or set an Error ** value > are decent enough to guarantee a NULL return when reporting an error. > Not so with our generated qapi visitor functions. If the caller > is not careful to clean up partially-allocated objects on error, > then the caller suffers a memory leak. > > Properly fixing it is probably complex enough to save for a later > day, so merely document it for now. > > Signed-off-by: Eric Blake Picked into my series. Thanks!